[Bug 1703307] Re: [SRU] Unable to rename tabs

[Simon Quigley]

As said before, the fix is in 0.3.0-2, but here's the diff between
0.3.0-1 and 0.3.0-2:
http://launchpadlibrarian.net/318978332/lxterminal_0.3.0-1_0.3.0-2.diff.gz

Part of this diff was released in 0.3.0-1ubuntu0.1 as a security update.
This was tracked in bug 1690416. The remaining delta (excluding the
changelog) is as follows:

diff -Nru lxterminal-0.3.0/debian/patches/02-fix-tab-name-dialog.diff lxterminal-0.3.0/debian/patches/02-fix-tab-name-dialog.diff
--- lxterminal-0.3.0/debian/patches/02-fix-tab-name-dialog.diff	1970-01-01 00:00:00.000000000 +0000
+++ lxterminal-0.3.0/debian/patches/02-fix-tab-name-dialog.diff	2017-05-09 04:13:07.000000000 +0000
@@ -0,0 +1,22 @@
+From: Yao Wei (魏銘廷) <mwei at lxde.org>
+Subject: fix: tab name renaming
+
+* fix: display dialog buttons for changing tab name
+
+Origin: upstream, https://git.lxde.org/gitweb/?p=lxde/lxterminal.git;a=commit;h=e2ad448556ee0f78ebdd0e36dc16e96702326fb6
+Bug: https://github.com/lxde/lxterminal/issues/30
+Bug-Debian: http://bugs.debian.org/862096
+
+--- a/src/lxterminal.c
++++ b/src/lxterminal.c
+@@ -573,8 +573,8 @@
+         _("Name Tab"),
+         GTK_WINDOW(terminal->window),
+         0,
+-        NULL, GTK_RESPONSE_CANCEL,
+-        NULL, GTK_RESPONSE_OK,
++        _("_Cancel"), GTK_RESPONSE_CANCEL,
++        _("_OK"), GTK_RESPONSE_OK,
+         NULL);
+     gtk_dialog_set_default_response(GTK_DIALOG(dialog), GTK_RESPONSE_OK);
+     if (gtk_icon_theme_has_icon(gtk_icon_theme_get_default(), "lxterminal"))
diff -Nru lxterminal-0.3.0/debian/patches/series lxterminal-0.3.0/debian/patches/series
--- lxterminal-0.3.0/debian/patches/series	1970-01-01 00:00:00.000000000 +0000
+++ lxterminal-0.3.0/debian/patches/series	2017-05-09 04:13:07.000000000 +0000
@@ -0,0 +1,2 @@
01-cve-2016-10369.diff
+02-fix-tab-name-dialog.diff

I think the best option at this point is to force sync 0.3.0-2 from
Buster (not Sid as 0.3.0-3 was uploaded and that is outside the scope of
this SRU) to Zesty. It wouldn't necessarily make a difference (I
believe) if we were to force sync versus just increasing the delta, but
it seems cleaner to me.

Thoughts?

** Bug watch added: github.com/lxde/lxterminal/issues #30
   https://github.com/lxde/lxterminal/issues/30

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1703307

Title:
  [SRU] Unable to rename tabs

Status in lxterminal package in Ubuntu:
  Fix Released
Status in lxterminal source package in Zesty:
  In Progress
Status in lxterminal source package in Artful:
  Fix Released
Status in lxterminal package in Debian:
  Fix Released

Bug description:
  [Original Description]

  The current lxterminal 0.3.0 has a bug that cannot rename tabs, which is
  fixed in an upstream commit:

  https://git.lxde.org/gitweb/?p=lxde/lxterminal.git;a=commit;h=e2ad448556ee0f78ebdd0e36dc16e96702326fb6

  [Impact]

  Without this fix, users are unable to rename a tab in LXTerminal by
  pressing Ctrl + Shift + I, as the OK and Close buttons are not
  present. This is a regression from the previous version, and should be
  fixed.

  [Test Case]

   1. Open LXTerminal.
   2. Press Ctrl + Shift + I

  Expected result:
   The user should be able to specify their own name for the tab, and either press Enter/Return on their keyboard or an OK button on the dialog box.

  Actual result:
   A dialog box is present allowing the user to change the text, but there are no OK or Close buttons present, and when the user presses Enter/Return on their keyboard, it does nothing.

  [Regression Potential]

  The potential for a regression to occur is unlikely, as the fix is
  simply defining strings for buttons:

  -        NULL, GTK_RESPONSE_CANCEL,
  -        NULL, GTK_RESPONSE_OK,
  +        _("_Cancel"), GTK_RESPONSE_CANCEL,
  +        _("_OK"), GTK_RESPONSE_OK,

  If the underlying GTK libraries change (which is, to be fair,
  extremely unlikely given that this is a stable release), it could
  maybe cause a regression, but it wouldn't be limited to lxterminal.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/lxterminal/+bug/1703307/+subscriptions