[Bug 1317491] Re: virsh blockcommit hangs at 100%

[Rafael David Tinoco]

Finishing Verification with @cpaelzer questions:

I like your tests in #12 and #18, but can you think and compare several
permutations of commits to non-active layers? Those should have worked
before as far as I read the comments.

What would that be base->s1->s2->s3 and then committing s3 to s2 ?

>> Demonstrated with 2, 3 and 4 snapshots ^^^^. Active can't be merged
by all other layers can. At the end you will always have AT LEAST a base
and the top layers (since the active can't be merged).

What about inactive guests, would it work then?

>> There is no way to merge volumes with inactive guests. It uses QEMU
block jobs and it needs to be running.

Move these tests, together with just the commands of #12 into the SRU
Teamplate in the description then please. To ease the SRU Teams work.

>> Doing right now.

If you find any other invocation of block commit (e.g. to non active)
that works today, list breaking that in regression potential please.

>> All layers in RO mode (intermediate status). Will do.

Considering this verified. Thank you Christian.

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1317491

Title:
  virsh blockcommit hangs at 100%

Status in libvirt package in Ubuntu:
  Fix Released
Status in libvirt source package in Trusty:
  Fix Committed
Status in libvirt source package in Xenial:
  Fix Released
Status in libvirt source package in Yakkety:
  Fix Released
Status in libvirt source package in Zesty:
  Fix Released

Bug description:
  [Impact]

   * Virsh can't merge snapshots using the Block Commit technique
   * It is only possible to merge base to top image (not the opposite)
   * Combination of libvirt v1.2.2 and QEMU 2 is no good for Block Commit
   * After this fix, virsh won't hang on the opration, will cause an error

  [Test Case]

  $ virsh list --all
   Id    Name                           State
  ----------------------------------------------------
   4     guest                          running

  $ virsh domblklist --domain guest
  Target     Source
  ------------------------------------------------
  vda        /var/lib/libvirt/images/guest.1487880011

  $ sudo qemu-img info --backing-chain /var/lib/libvirt/images/guest.1487880011 | grep image:
  image: /var/lib/libvirt/images/guest.1487880011
  image: /var/lib/libvirt/images/guest.qcow2

  inaddy@(kvm02):~$ virsh blockcommit --domain=guest --path=/var/lib/libvirt/images/guest.1487880011 --base=/var/lib/libvirt/images/guest.qcow2 --wait --verbose
  Block Commit: [100 %] <----- STUCKS HERE

  [Regression Potential]

   * Block commit for Active layers would continue not working
   * Block commit for Intermediary layers would not work
   * Its a small fix based on upstream fix (to block this function)
   * Has been tested a lost on verification

  [Other Info]

  ## Original Case Description

  virsh blockcommit hangs at 100% and nothing happens.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1317491/+subscriptions