[Bug 1317491] Re: virsh blockcommit hangs at 100%

ChristianEhrhardt 1317491 at bugs.launchpad.net
Wed Feb 22 08:57:30 UTC 2017


Hi Rafael,

Not so important but FYI your link in the description is broken - it
leads me to some weird catching site, not really an emulatortalk.info
with some content.

I like your tests in #12 and #18, but can you think and compare several
permutations of commits to non-active layers? Those should have worked
before as far as I read the comments.

What would that be base->s1->s2->s3 and then committing s3 to s2 ? 
What about inactive guests, would it work then?

You are certainly more into the topic, so I'd like to ask you to create these tests and check that these still behave as intended (or better).
This is meant to catch and issues where the change from:
 if (topSource == &disk->src) {
to
  if (top_meta == disk->backingChain) {
due to the backporting might cause issues.

Move these tests, together with just the commands of #12 into the SRU
Teamplate in the description then please. To ease the SRU Teams work.

If you find any other invocation of block commit (e.g. to non active)
that works today, list breaking that in regression potential please.

Other than that I really think the patch is fine, and what I asked for
can/should be done as part of the verification in proposed IMHO - that
said, sponsoring now (after a build test).

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1317491

Title:
  virsh blockcommit hangs at 100%

Status in libvirt package in Ubuntu:
  Fix Released
Status in libvirt source package in Trusty:
  In Progress
Status in libvirt source package in Xenial:
  Fix Released
Status in libvirt source package in Yakkety:
  Fix Released
Status in libvirt source package in Zesty:
  Fix Released

Bug description:
  [Impact]

   * Virsh can't merge snapshots using the Block Commit technique
   * It is only possible to merge base to top image (not the opposite)
   * Combination of libvirt v1.2.2 and QEMU 2 is no good for Block Commit
   * After this fix, virsh won't hang on the opration, will cause an error

  [Test Case]

   * Workaround in Commit #10
   * QEMU is fine in Commit #11
   * Test Case in Commit #12

  [Regression Potential]

   * Block commit (Already broken) would continue not working
   * Its a small fix based on upstream fix (to block this function)

  [Other Info]
   
  ## Original Case Description

  virsh blockcommit hangs at 100% and nothing happens.

  I only found the following discussion:
  http://t358434.emulators-libvirt-user.emulatortalk.info/virsh-blockcommit-hangs-at-100-t358434.html

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1317491/+subscriptions



More information about the Ubuntu-sponsors mailing list