[Bug 1246245] [NEW] proftpd service fails to restart (including via logrotate)

[Launchpad Bug Tracker]

You have been subscribed to a public bug by Brian Morton (rokclimb15):

SRU request for Trusty

[Impact]

 * ProFTPd exits with signal 15 when restarted via init script.
   Worse yet, init script returns success.

 * Since logrotate runs via cron and performs a restart, this causes
   FTP service to stop and results in unexpected service downtime.

 * Final version of upstream patch at https://anonscm.debian.org/git
/pkg-proftpd/proftpd-
dfsg.git/commit/?id=23c5e44b3c30a082a0e15279961c3c4c3d7393fd

 * Only trusty and prior are affected

[Test Case]

 * bmorton at maui:~$ sudo service proftpd restart
   * Stopping ftp server proftpd                                           [ OK ]
   * Starting ftp server proftpd                                           [ OK ]
   bmorton at maui:~$ sudo service proftpd status
   ProFTPD is started in standalone mode, currently not running.

 * After a restart, status should say "currently running"

[Regression Potential]

 * Failure to start/stop/restart proftpd service

 * Patched package currently running on production host without issues

[Other Info]

 * This is a very old bug affecting a substantial number of users

 * Early AM nagios notifications about FTP service are undesirable

-------------------------------------------------------------------------

proftpd-basic 1.3.5~rc3-2 from Ubuntu 13.10
proftpd-basic 1.3.5~rc3-2.1ubuntu2 from Ubuntu 14.04

Init script from proftpd-basic package contains the BUG: when you run
/etc/init.d/proftpd restart it fails because of there is the race
between pidfile removal and start() which checks pidfile existency:

---
ProFTPD is started in standalone mode, currently running.
root at aa:~# /etc/init.d/proftpd restart
 * Stopping ftp server proftpd                                                                                                                                                                             [ OK ]
 * Starting ftp server proftpd                                                                                                                                                                             [ OK ]
root at aa:~# /etc/init.d/proftpd status
ProFTPD is started in standalone mode, currently not running.
---

the next workaround helps:

---
--- /etc/init.d/proftpd.orig    2013-10-30 13:52:46.791265726 +0400
+++ /etc/init.d/proftpd 2013-10-30 13:52:57.456265698 +0400
@@ -107,6 +107,7 @@
     fi
     if [ -f "$PIDFILE" ]; then
        start-stop-daemon --stop --signal $SIGNAL --quiet --pidfile "$PIDFILE"
+       sleep 1
         if [ $? = 0 ]; then
                log_end_msg 0
        else
---

Please, fix.

** Affects: proftpd-dfsg (Ubuntu)
     Importance: Undecided
     Assignee: Brian Morton (rokclimb15)
         Status: Confirmed

** Affects: proftpd-dfsg (Ubuntu Trusty)
     Importance: Undecided
         Status: New

-- 
proftpd service fails to restart (including via logrotate)
https://bugs.launchpad.net/bugs/1246245
You received this bug notification because you are a member of Ubuntu Sponsors Team, which is subscribed to the bug report.