[Bug 1620407] Re: vm startup broken when interface definition has script tag

[ChristianEhrhardt]

Yep, the bisect hit the change that I assumed 9c17d665fdc5f "autocreate
tap device for ethernet network type".

The upstream "fix" now known and understood I agree way more with your
fix now. To backport the upstream version is much more of a feature and
large scale impact than the fix you provided.

I'm planning to include that in the next Xenial SRU I'm doing for
libvirt after I had the chance to give it some extra tests to confirm
there is no unexpected side-effect.

** Changed in: libvirt (Ubuntu Xenial)
       Status: Triaged => In Progress

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1620407

Title:
  vm startup broken when interface definition has script tag

Status in libvirt package in Ubuntu:
  Fix Released
Status in libvirt source package in Xenial:
  In Progress

Bug description:
  Ubuntu 16.04.1 LTS (amd64)
  libvirt-bin 1.3.1-1ubuntu10.1

  We use external scripts to setup tap interfaces, e.g.

      <interface type='ethernet'>
        <mac address='52:54:00:18:0d:a3'/>
        <script path='/etc/libvirt/14v/mf_testet.sh'/>
        <target dev='mf_testet'/>
        <model type='virtio'/>
        <address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x0'/>
      </interface>

  Starting the VM throws an error message ("interface not found" or
  something like that).

  IIUC, the script invocation is done by qemu, so the interface
  may not yet exist when libvirt is constructing the qemu cmd args.
  Checking for that interface in advance therefore is a bug.

  Attached patch skips the check if a <script> parameter is provided.

  Regards
  Matthias Ferdinand

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1620407/+subscriptions