[Bug 1669818] Re: Ubuntu Budgie shows debian wallpaper due to greeter recommendation / lightdm-gtk-greeter does not compile

[Robie Basak]

Hi David,

I took a brief look at your proposed upload for lightdm-gtk-greeter
2.0.2-1ubuntu1. I'm afraid it doesn't follow what we usually expect for
an Ubuntu merge so cannot be uploaded to Ubuntu as-is.

Things I noticed:

Your merge entry in debian/changelog doesn't follow our convention on
writing up a merge. In particular it doesn't detail the Ubuntu delta
that is still remaining, or what has been dropped, or what aspects you
have changed. This makes it difficult for me to review anything else,
since I don't know what you have done that is intentional, nor reasons
why, so I cannot tell apart what looks odd to me and what you have done
that could be an accident.

You're clobbering entries in debian/changelog from the old Ubuntu;
instead I'd expect only entries to be added to the top of
debian/changelog from what Zesty has currently. You can use dpkg-
mergechangelogs to achieve this manually if you wish.

You have "un-run" update-maintainer.

You have regressed Standards-Version from 3.9.8 back to 3.9.6.

The addition of the Breaks/Replaces in debian/control looks correct to
me, but is not documented in debian/changelog.

Please could you study how to do an "Ubuntu merge"? Probably the best
way is to study some other simple merges that are already uploaded.
Please do ask for help if you need it, and resubscribe ~ubuntu-sponsors
when you're ready.

What I expect to see is:

Each previous part of the Ubuntu delta identified in the changelog and
either noted as dropped, retained or modified, with the reason being
clear enough for another Ubuntu delta to understand. The actual delta
retained, dropped or modified exactly as noted. debian/changelog merged
in (new both previous Ubuntu and new Debian changelog entries present).


For budgie-artwork 0.7.2:

You're renaming something that lands in etc/lightdm/lightdm-gtk-
greeter.conf.d/ presumably, so doesn't this need conffile renaming via
dpkg-maintscript-helper or a debian/<package>.maintscript debhelper file
if using debhelper?


As I think there's nothing to upload pending answers to these questions, I'll unsubscribe ~ubuntu-sponsors for now. Please resubscribe ~ubuntu-sponsors again when you're ready.

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1669818

Title:
  Ubuntu Budgie shows debian wallpaper due to greeter recommendation /
  lightdm-gtk-greeter does not compile

Status in budgie-artwork package in Ubuntu:
  In Progress
Status in lightdm-gtk-greeter package in Ubuntu:
  In Progress

Bug description:
  Ubuntu Budgie, like Xubuntu uses lightdm-gtk-greeter as its default
  greeter.

  However, due to the recommendation of "debian-base" in debian/control,
  we show all the debian wallapers in that package.  Very confusing for
  users.

  Please can this be changed to a "Suggests:" instead?

  Note - I originally asked this Q on Debian, but they declined saying
  its a downstream issue

   - https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=850328

  I was going to attach a debdiff for the change, but the current source
  for lightdm-gtk-greeter zesty does not compile under zesty due to
  lightDM API changes.  Was the package simply copied from Xenial?
  Which begs the question - how on earth does the greeter actually work
  under zesty if the API has changed!

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/budgie-artwork/+bug/1669818/+subscriptions