[Bug 1624832] Re: [SRU] AUTORCC-generated resources always out-of-date with Ninja

[LocutusOfBorg]

patch fixing the issue

build ongoing at ppa:costamagnagianfranco/costamagnagianfranco-ppa
https://launchpad.net/~costamagnagianfranco/+archive/ubuntu/costamagnagianfranco-ppa

** Summary changed:

- AUTORCC-generated resources always out-of-date with Ninja
+ [SRU] AUTORCC-generated resources always out-of-date with Ninja

** Description changed:

- When using AUTORCC with the Ninja generator, the generated qrc_*.cpp.o
- target is always considered out-of-date, leading to an unnecessary (and
- possibly lengthy) re-link on each build. This defeats one of the main
- strengths of Ninja, which is its fast no-op build time.
+ [Impact]
+ 
+  * people using Ninja to speed up the build, with AUTORCC-generated
+ resources
+ 
+ [Test Case]
+ 
+  * stuff is not regenerated due to a bug in cmake
+ 
+ [Regression Potential]
+ 
+  * None
+ 
+ [Other Info]
  
  The upstream bug report is here:
  
      https://cmake.org/Bug/view.php?id=16049
  
  and was later moved to here:
  
      https://gitlab.kitware.com/cmake/cmake/issues/16049
  
  It was fixed by Brad King in
  
  https://gitlab.kitware.com/ben.boeckel/cmake/commit/f6c5958047ee8a9084bf230a6c1acb4801cb2b93
  
  and the fix is in CMake 3.5.2.
  
  I would like to ask what is best: Should I should prepare a debdiff
  adding this patch to the 3.5.1 package in Xenial and request an SRU? Or
  is it reasonable to update the Xenial package to 3.5.2 (which is in
  Yakkety) outright?

** Attachment added: "debdiff"
   https://bugs.launchpad.net/ubuntu/+source/cmake/+bug/1624832/+attachment/4748881/+files/debdiff

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1624832

Title:
  [SRU] AUTORCC-generated resources always out-of-date with Ninja

Status in cmake package in Ubuntu:
  New

Bug description:
  [Impact]

   * people using Ninja to speed up the build, with AUTORCC-generated
  resources

  [Test Case]

   * stuff is not regenerated due to a bug in cmake

  [Regression Potential]

   * None

  [Other Info]

  The upstream bug report is here:

      https://cmake.org/Bug/view.php?id=16049

  and was later moved to here:

      https://gitlab.kitware.com/cmake/cmake/issues/16049

  It was fixed by Brad King in

  https://gitlab.kitware.com/ben.boeckel/cmake/commit/f6c5958047ee8a9084bf230a6c1acb4801cb2b93

  and the fix is in CMake 3.5.2.

  I would like to ask what is best: Should I should prepare a debdiff
  adding this patch to the 3.5.1 package in Xenial and request an SRU?
  Or is it reasonable to update the Xenial package to 3.5.2 (which is in
  Yakkety) outright?

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/cmake/+bug/1624832/+subscriptions