[Bug 1606940] Re: A a single PCI read or write appears twice on the PCIe bus. This happens when using the SR-IOV feature with some PCI devices

[ChristianEhrhardt]

Intel
http://www.intel.com/content/dam/www/public/us/en/documents/datasheets/ethernet-x540-datasheet.pdf
(for my case) defines in section 9.5 the configuration space for the VF.

Most entries are RO for the VF, and I found no writable register bit
behaving in a similar manner than the referred "adding register", but I
might overlook something.

Ryan could you still verify this or are more experienced to find such a
reg for me in the spec?

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to a duplicate bug report (1563375).
https://bugs.launchpad.net/bugs/1606940

Title:
  A a single PCI read or write appears twice on the PCIe bus. This
  happens when using the SR-IOV feature with some PCI devices

Status in qemu package in Ubuntu:
  Fix Released
Status in qemu source package in Trusty:
  Fix Committed

Bug description:
  [Impact]

   * Users of SRIOV devices in qemu on Trusty may encounter unstable
     behavior on pass-through PCI devices due to a bug in qemu's MMIO
     mapping to overlapping ram slots. When memory is accessed in
     subpage granularity where slots have overlapping regions multiple
     invocations of the handler ocurrs which resulted in multiple pci
     writes.

     This affects the qemu releases prior to qemu 2.5, it has been fixed in
     newer releases.

   * Backporting fixes from upstream release is required to allow
     certain PCI devices under SRIOV to function properly.

   * All patches applied are already accepted upstream. Xenial, Yakkety
     are OK, Wily -> Trusty are affected.

  [Test Case]

   * On a Trusty 14.04 system with affected SRIOV device.
      - boot system with sriov enabled
      - launch vm with sriov device passed through
        using guest XML attached (bug-1606940-trusty-guest.xml)
      - unpack pcimem tarball inside vm (pcimem.tar attached)
      - Read (note the pci path should point to the SRIOV device)
       ./pcimem /sys/bus/pci/devices/0000\:04\:00.0/resource0 0x10080 d
      - Write
       ./pcimem /sys/bus/pci/devices/0000\:04\:00.0/resource0 0x10080 d 2048
      - Read again
       ./pcimem /sys/bus/pci/devices/0000\:04\:00.0/resource0 0x10080 d

      The value of 0x10080 should be the same for the first read
      and the second read, after the write.

      If the bug is hit, the second read will report a value of double
      instead of the same.

  [Regression Potential]

   * SR-IOV device drivers may have unknowingly relied on KVM multi-write
     behavior prior to this patch; that's highly unlikely since it would
     fail on physical hardware (which does not produce this effect). But
     there is a chance that devices only passed into the guest via SRIOV
     might break.

  [Original Description]
  Customer engineers are testing the SR-IOV feature with a new network card on x86 servers and ran into the issue described below.

  They are *not* seeing this issue on Intel 82599 NIC.

  We are testing a new device in EP mode with SRIOV.  With a CentOS7 VM
  running on the Ubuntu 14.04.2 host (using VFIO) we see that a single
  PCI read or write transaction targeting the device’s BAR0 issued from
  the VM appears twice on the PCIe bus. The same accesses work fine when
  the VF is accessed directly from the Ubuntu 14.04.2 host. These BAR0
  PCI accesses do not require a driver on the VM side. We can reproduce
  the problem using a simple user-space application to access the VF’s
  BAR0 registers.

  We do not see this problem when the VM runs within a CentOS 7 host or
  under a Ubuntu 12.04 host. This appears specific to Ubuntu 14.04
  release. Appreciate your help in any clues or pointers to this
  behavior.

  This issue is also not happening with 16.04 beta.

  Steps to reproduce the bug with pcimem:

  Read:
  ./pcimem /sys/bus/pci/devices/0000\:04\:00.0/resource0 0x10080 d

  Write:
  ./pcimem /sys/bus/pci/devices/0000\:04\:00.0/resource0 0x10080 d 2048

  Read again:
  ./pcimem /sys/bus/pci/devices/0000\:04\:00.0/resource0 0x10080 d

  The value of 0x10080 should be the same for the first read and the
  second read, after the write.

  If the bug is hit, the second read will report a value of double
  instead of the same.

  The register should have read back the same value that was written.
  The register acts like an adder in that every write adds to the
  previously written value minus anything the device has consumed. We
  see that the second read returns double the value written in the
  single write. We captured a PCIe trace and found that each of the PCI
  operation accessing this register is seen twice on the PCI bus. The 2
  writes cause the register value to double which has implications for
  normal operation. The PCIe trace is attached and has markers to
  identify the relevant transactions.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1606940/+subscriptions