[Bug 1607920] Re: zfs services fail on firstboot if zfs-utils is integrated into the deployment image

[Andy Whitcroft]

@Eric -- I am concerned about the effect of some of these changes on
translations.  For example the below will make the format string a new
translatable and therefore will not be translated for non english
locales.  If we simply replaces MNTTAB with "/etc/mtab" the translatable
string would be unchanged:

+               (void) fprintf(stderr, gettext(
+-                  "filesystem '%s' was mounted, but %s "
++                  "filesystem '%s' was mounted, but /etc/mtab "
+                   "could not be opened due to error %d\n"),
+-                  dataset, MNTTAB, errno);
++                  dataset, errno);

There are a few like that.

Also as you are changing MNTTAB is there any reason not to be using that
here?

+-              (void) fprintf(stderr, gettext("warning: %s not in mtab\n"),
+-                  path);
++              (void) fprintf(stderr, gettext("warning: %s not in"
++                  "/proc/self/mounts\n"), path);

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1607920

Title:
  zfs services fail on firstboot if zfs-utils is integrated into the
  deployment image

Status in sysvinit package in Ubuntu:
  Won't Fix
Status in zfs-linux package in Ubuntu:
  Fix Released
Status in sysvinit source package in Xenial:
  Won't Fix
Status in zfs-linux source package in Xenial:
  In Progress

Bug description:
  [Impact]

   * zfs services fail on firstboot if zfs-utils is integrated into the
  deployment image.

   * Output from systemd -
  sudo systemctl --failed
  UNIT LOAD ACTIVE SUB DESCRIPTION
  ● zfs-import-scan.service loaded failed failed Import ZFS pools by device scanning
  ● zfs-mount.service loaded failed failed Mount ZFS filesystems

   * This is particularly frustrating for users who use automated
  monitoring as it means virtual machines must always be restarted
  before showing as clean.

   * This failure is due to zfs services starting up before /etc/mtab
  has a chance to be symlinked to /proc/mounts.

  [Test Case]

   1. Grab a stock xenial image, and unpack it and add zfs-utils to it.  Repack it.
   2. Boot machine
   3. Check systemctl --failed.

  [Regression Potential]

   * none expected, patch has been intensively tested by the upsteam zfs
  test script suite.

   * This is a upstream commit merge in 0.7.0.

   * A ubuntu package has been tested (including the upstream commit) by
  a user of the community facing this bug, and confirmed it addresses
  the problem (see comment #7).

  [Other Info]

  * The "reading" is redirected to /proc/self/mounts. 
  The writing to /etc/mtab. Some distros still need that. The current hope is to replace the writing (and maybe reading) with libmount, in a second phase.

  
   * Upstream commit : https://github.com/zfsonlinux/zfs/commit/792517389fad5c495a2738b61c2e9c65dedaaa9a

   * Upstream bug: https://github.com/zfsonlinux/zfs/issues/4680

   * Debian bug : https://bugs.debian.org/cgi-
  bin/bugreport.cgi?bug=839071

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/sysvinit/+bug/1607920/+subscriptions