[Bug 1374663] Re: [SRU] agent/linux/ip_lib.py does not correctly handle output from 'iproute2' command

[Brian Murray]

Hello Lars, or anyone else affected,

Accepted neutron into trusty-proposed. The package will build now and be
available at
https://launchpad.net/ubuntu/+source/neutron/1:2014.1.5-0ubuntu7 in a
few hours, and then in the -proposed repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to
enable and use -proposed.  Your feedback will aid us getting this update
out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested, and change the tag
from verification-needed to verification-done. If it does not fix the
bug for you, please add a comment stating that, and change the tag to
verification-failed.  In either case, details of your testing will help
us make a better decision.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance!

** Changed in: neutron (Ubuntu Trusty)
       Status: In Progress => Fix Committed

** Tags added: verification-needed

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1374663

Title:
  [SRU] agent/linux/ip_lib.py does not correctly handle output from
  'iproute2' command

Status in Ubuntu Cloud Archive:
  Fix Released
Status in Ubuntu Cloud Archive icehouse series:
  In Progress
Status in neutron:
  Fix Released
Status in neutron package in Ubuntu:
  Fix Released
Status in neutron source package in Trusty:
  Fix Committed

Bug description:
  [Impact]

   * The get_devices() method in neutron/agent/linux/ip_lib.py chokes if 'iproute2' presents interface names containing '@', such as ipip tunnels and macvlan devices:
    
  		tunl0 at NONE: <NOARP> mtu 1480 qdisc noop state DOWN mode DEFAULT group default
  		clone at eth0: <BROADCAST,MULTICAST> mtu 1454 qdisc noop state DOWN mode DEFAULT
          
    * The mere presence of one of the above interface names will cause the
      code to fail with:

  		RuntimeError:
  		Command: ['ip', 'addr', 'show', 'tunl0 at NONE']
  		Exit code: 1
  		Stdout: ''
  		Stderr: 'Device "tunl0 at NONE" does not exist.\n'

  
  [Test Case]

   * This has been seen in the vpn_agent.log after upgrading to a xenial kernel (4.4.0-45-generic) in a trusty/icehouse environment.
     
      /var/log/neutron/vpn_agent.log:
      ERROR neutron.agent.linux.interface [-] Failed unplugging interface   'qg-e75da35-63 at if10' 

  
  [Regression Potential]

    * iproute2 is still used, however, a search path was added
  (/sys/class/net) which returns the interfaces without the '@'.

    * This has been fixed since Kilo so there is minimal regression
  potential.

  
  [ Other Info ]

    *

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/1374663/+subscriptions