[Bug 1576780] Re: Needs to implement the full DEP-11 icon spec for compatibility with 3rd-party repos

[Matthias Klumpp]

Works perfectly here, thanks!
@Neil: Can you test this too?

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1576780

Title:
  Needs to implement the full DEP-11 icon spec for compatibility with
  3rd-party repos

Status in appstream-glib package in Ubuntu:
  Fix Released
Status in appstream-glib source package in Xenial:
  Fix Committed

Bug description:
  [Impact]

   * The AppStream YAML spec describes a way to include width/height properties in cached-icon metadata, which isn't forward-compatible to the old spec.
   * asglib doesn't implement the full spec in the release present in Xenial, so it ignores cached icons with size info, as well as it doesn't support several features present in the spec, e.g. the remote icon type.
   * This leads to AppStream components from 3rd-party repos/PPAs not showing up in GNOME Software, since asglib is unable to find icons if they use a more recent version of the spec.
   * The attched patch fixes this.

  [Test Case 1]

   * Close all instances of GNOME Software (also the background daemon!)
   * Launch GNOME Software again: All apps should be present, you should notice no change.

  [Test Case 2]

   * Close all instances of GNOME Software (also the background daemon!)
   * Get new-style metadata, e.g. from Elementary or Debian[1], or simply add the SIL repo which is shipping that metadata now: http://packages.sil.org/ (that would be the easiest way to test)
   * Launch GNOME Software again: All apps should be present, including the 3rd-party ones (search for "FieldWorks").

  [1]: ftp://ftp.debian.org/debian/dists/stretch/main/dep11/

  [Regression Potential]

   * This is adding a missing feature, restoring compatibility with 3rd-
  party repos. The existing data should be parsed as before, so I don't
  see much regression potential ("Test Case 1" needs to work)

  [Other Info]

   * This fix has been applied upstream: https://github.com/hughsie/appstream-glib/commit/628e3cfb1c62c3177d6decd86102217f2546e0a2
   * The fix is also present in Debian.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/appstream-glib/+bug/1576780/+subscriptions