[Bug 1579712] Re: Refresh hangs due to strdup on non-NULL terminated string

[Martin Pitt]

Hello Matthias, or anyone else affected,

Accepted appstream into xenial-proposed. The package will build now and
be available at
https://launchpad.net/ubuntu/+source/appstream/0.9.4-1ubuntu1 in a few
hours, and then in the -proposed repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to
enable and use -proposed.  Your feedback will aid us getting this update
out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested, and change the tag
from verification-needed to verification-done. If it does not fix the
bug for you, please add a comment stating that, and change the tag to
verification-failed.  In either case, details of your testing will help
us make a better decision.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance!

** Changed in: appstream (Ubuntu Xenial)
       Status: New => Fix Committed

** Tags added: verification-needed

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1579712

Title:
  Refresh hangs due to strdup on non-NULL terminated string

Status in appstream package in Ubuntu:
  Fix Committed
Status in appstream source package in Xenial:
  Fix Committed

Bug description:
  [Impact]

   * The cache refresh is blocked on a strdup on a non-NULL-terminated string in some very rare occasions (very rare because this bug is present for almost 3y without a single report).
   * Fixing this bug resolves the issue for people who might experience it.
   * See https://github.com/ximion/appstream/issues/35 for details.

  [Test Case 1]

   * Run `sudo appstreamcli refresh --force`
   * The AppStream cache should be updated, no change in behavior should be seen.

  [Test Case 2]

   * In case you were experiencing the almost-infinite hang when running
  `sudo appstreamcli refresh --force`, this issue should be fixed with
  the SRU.

  [Regression Potential]

   * Very low, since this only fixes the decompression code. There
  should be no sideeffects of that (given that the patch itself doesn't
  break anything, which it shouldn't, since it has been tested upstream
  for a while)

  [Other Info]

   * This fix has been applied upstream: https://github.com/ximion/appstream/commit/f33c520c37e2ba51d92402220250b8d501a2bf43
   * A smaller version of the patch (one-liner) is available, at the expense of not having reduced memory usage: https://github.com/ximion/appstream/commit/378941787d3584b3eb31a6ebe40e0aacc10e180a

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/appstream/+bug/1579712/+subscriptions