[Bug 1579712] [NEW] Refresh hangs due to strdup on non-NULL terminated string

[Launchpad Bug Tracker]

You have been subscribed to a public bug by Ubuntu Foundations Team Bug Bot (crichton):

[Impact]

 * The cache refresh is blocked on a strdup on a non-NULL-terminated string in some very rare occasions (very rare because this bug is present for almost 3y without a single report).
 * Fixing this bug resolves the issue for people who might experience it.
 * See https://github.com/ximion/appstream/issues/35 for details.

[Test Case 1]

 * Run `sudo appstreamcli refresh --force`
 * The AppStream cache should be updated, no change in behavior should be seen.

[Test Case 2]

 * In case you were experiencing the almost-infinite hang when running
`sudo appstreamcli refresh --force`, this issue should be fixed with the
SRU.

[Regression Potential]

 * Very low, since this only fixes the decompression code. There should
be no sideeffects of that (given that the patch itself doesn't break
anything, which it shouldn't, since it has been tested upstream for a
while)

[Other Info]

 * This fix has been applied upstream: https://github.com/ximion/appstream/commit/f33c520c37e2ba51d92402220250b8d501a2bf43
 * A smaller version of the patch (one-liner) is available, at the expense of not having reduced memory usage: https://github.com/ximion/appstream/commit/378941787d3584b3eb31a6ebe40e0aacc10e180a

** Affects: appstream (Ubuntu)
     Importance: Medium
         Status: Fix Committed


** Tags: patch
-- 
Refresh hangs due to strdup on non-NULL terminated string
https://bugs.launchpad.net/bugs/1579712
You received this bug notification because you are a member of Ubuntu Sponsors Team, which is subscribed to the bug report.