[Bug 1530837] Re: Logsys file leaks in /dev/shm after sigabrt, sigsegv and when running corosync -v

[Chris J Arges]

Hello Rafael, or anyone else affected,

Accepted corosync into trusty-proposed. The package will build now and
be available at
https://launchpad.net/ubuntu/+source/corosync/2.3.3-1ubuntu2 in a few
hours, and then in the -proposed repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to
enable and use -proposed.  Your feedback will aid us getting this update
out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested, and change the tag
from verification-needed to verification-done. If it does not fix the
bug for you, please add a comment stating that, and change the tag to
verification-failed.  In either case, details of your testing will help
us make a better decision.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance!

** Changed in: corosync (Ubuntu Trusty)
       Status: In Progress => Fix Committed

** Tags added: verification-needed

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1530837

Title:
  Logsys file leaks in /dev/shm after sigabrt, sigsegv and when running
  corosync -v

Status in corosync package in Ubuntu:
  Fix Released
Status in corosync source package in Trusty:
  Fix Committed

Bug description:
  [Impact]

   * corosync has a memory leak problem with multiple calls to corosync -v
   * corosync has a memory leak problem by not properly handling signals

  [Test Case]

   * run "corosync -v" multiple times
   * some cloud tools do that

  [Regression Potential] 
   
   * minor code changes on not-core code
   * based on upstream changes
   * based on a redhat fix

  [Other Info]

  # Original BUG Description

  It was brought to my attention that Ubuntu also suffers from:

  https://bugzilla.redhat.com/show_bug.cgi?id=1117911

  And corosync should include the following fixes:

  ----

  commit dfaca4b10a005681230a81e229384b6cd239b4f6
  Author: Jan Friesse <jfriesse at redhat.com>
  Date: Wed Jul 9 15:52:14 2014 +0200

  Fix compiler warning introduced by previous patch

  QB loop signal handler prototype differs from signal(2) prototype.
  Solution is to create wrapper functions.

  Signed-off-by: Jan Friesse <jfriesse at redhat.com>

  commit 384760cb670836dc37e243f594612c6e68f44351
  Author: zouyu <hopkings2005 at gmail.com>
  Date: Thu Jul 3 10:56:02 2014 +0800

  Handle SIGSEGV and SIGABRT signals

  SIGSEGV and SIGABRT signals are now correctly handled (blackbox is
  dumped and logsys is finalized).

  Signed-off-by: zouyu <hopkings2005 at gmail.com>
  Reviewed-by: Jan Friesse <jfriesse at redhat.com>

  commit cc80c8567d6eec1d136f9e85d2f8dfb957337eef
  Author: zouyu <hopkings2005 at gmail.com>
  Date: Wed Jul 2 10:00:53 2014 +0800

  fix memory leak produced by 'corosync -v'

  Signed-off-by: zouyu <hopkings2005 at gmail.com>
  Reviewed-by: Jan Friesse <jfriesse at redhat.com>

  ----

  Description from Red Hat bug:

  """
  Description of problem:
  When corosync receives sigabrt or sigsegv it doesn't delete libqb blackbox file (/dev/shm one). Same happens when corosync is executed with -v parameter (this shows only version, so it shouldn't cause leak in /dev/shm).

  Version-Release number of selected component (if applicable):
  7.0

  How reproducible:
  100%

  Steps to Reproduce 1:
  1. Start corosync
  2. Send sigabrt to corosync

  Steps to Reproduce 1:
  1. Execute corosync -v

  Actual results:
  File like qb-corosync-*-blackbox-data|header exists results in leak of /dev/shm space.

  Expected results:
  No leak

  Additional info:
  """

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/corosync/+bug/1530837/+subscriptions