[Bug 1318317] Re: openipmi startup script removes kernel modules

[Breno Leitão]

Jeremy is on vacation, but I just tested this version on -proposed, and
it seems to be working fine:

ubuntu at ubuntu1404:~$ lsmod | grep ipmi
ipmi_watchdog          22705  0 
ipmi_poweroff          11629  0 
ipmi_devintf           13347  0 
ipmi_msghandler        51294  3 ipmi_devintf,ipmi_poweroff,ipmi_watchdog
ubuntu at ubuntu1404:~$  service openipmi stop
 * Stopping ipmi drivers.                                                                                                                         * may be in use
                                                                                                                                          [ OK ]
ubuntu at ubuntu1404:~$ lsmod | grep ipmi
ipmi_watchdog          22705  0 
ipmi_poweroff          11629  0 
ipmi_devintf           13347  0 
ipmi_msghandler        51294  3 ipmi_devintf,ipmi_poweroff,ipmi_watchdog
ubuntu at ubuntu1404:~$ sudo service openipmi stop
 * Stopping ipmi drivers.                                                                                                                 [ OK ] 
ubuntu at ubuntu1404:~$ lsmod | grep ipmi
ipmi_watchdog          22705  0 
ipmi_poweroff          11629  0 
ipmi_msghandler        51294  2 ipmi_poweroff,ipmi_watchdog
ubuntu at ubuntu1404:~$ service openipmi start
 * Starting ipmi drivers                                                                                                                  [fail] 
                                                                                                                                          [ OK ]
ubuntu at ubuntu1404:~$ lsmod | grep ipmi
ipmi_watchdog          22705  0 
ipmi_poweroff          11629  0 
ipmi_msghandler        51294  2 ipmi_poweroff,ipmi_watchdog


** Tags removed: verification-needed
** Tags added: verification-done

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1318317

Title:
  openipmi startup script removes kernel modules

Status in openipmi package in Ubuntu:
  Fix Released
Status in openipmi source package in Trusty:
  Fix Committed

Bug description:
  I need some IPMI kernel modules, so I load them during startup. This
  worked quite well until I upgraded to Ubuntu 14.04.

  As you can see I have the modules in /etc/modules:

  # grep ipmi /etc/modules
  ipmi_watchdog
  ipmi_devintf
  ipmi_poweroff
  ipmi_si

  Right after reboot, the modules are there:

  # lsmod |grep -i ipm
  ipmi_si                53257  2
  ipmi_poweroff          14366  0
  ipmi_devintf           17572  0
  ipmi_watchdog          24912  0

  but disappear after a few seconds/minute. I found out, that the cause
  is the /etc/init.d/openipmi script. The behaviour of the script is
  quite strange because a stop/start will behave differently then a
  restart.

  I loaded the modules manually using modprobe:
  ipmi_si                53257  2
  ipmi_poweroff          14366  0
  ipmi_devintf           17572  0
  ipmi_watchdog          24912  0

  when I execute:
  # service openipmi stop

  the module ipmi_devintf gets removed:

  ipmi_si                53257  2
  ipmi_poweroff          14366  0
  ipmi_watchdog          24912  0

  starting the service again with:

  # service openipmi start

  will remove ALL IPMI kernel modules:

  # lsmod |grep -i ipm
  #

  One of the reasons seems to be the module ipmi_msghandler. This is
  already integrated and causes some of the problems.

  When I remove it from /etc/init.d/openipmi like this:

  65,66c65
  < #MODULES_BASE="ipmi_msghandler"
  < MODULES_BASE=""
  ---
  > MODULES_BASE="ipmi_msghandler"
  325,326c324,325
  < #	modprobe ipmi_msghandler > /dev/null 2>&1
  < #	modules_loaded ipmi_msghandler
  ---
  > 	modprobe ipmi_msghandler > /dev/null 2>&1
  > 	modules_loaded ipmi_msghandler

  stoping and starting the service works again. But restarting the
  service will still remove all modules and will not load them anymore.

  [Impact]
  Issuing `service openipmi {start,stop,restart}` failures lead to unloading of IPMI modules that were previously loaded. Particularly on OpenPower systems, but also on others, this will result in 'ipmi_devintf' being unloaded during boot, and in-band IPMI being non-functional (amongst other IPMI functionality).

  [Test Case]
  On an OpenPower machine (this also happens on an appropriately configured (meaning without IPMI support) Intel qemu instance), load IPMI modules (in particular, ipmi_devintf, but any of them can be affected). Attempt to start the openipmi service with `service openipmi start`. Without the fix proposed, here, the ipmi_devintf module is unloaded. With the fix, the module stays loaded.

  [Regression Potential]
  The primary risk of regression is if an end-user was relying on the behavior of an error during openipmi initialization resulting in disabling of all IPMI functionality. I don't think that is reasonable behavior to rely on, though (and is not clearly documented anywhere as expected).

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/openipmi/+bug/1318317/+subscriptions