[Bug 1571295] Re: pptpd module config loaded at wrong location

[ChristianEhrhardt]

In my self-review I found a stray change (Add Documentation key to systemd service file) from 1.4.0-8 in the debdiff which I removed.
Uploading v3 for review and upload.

** Patch added: "backport of fix from debian - v3"
   https://bugs.launchpad.net/ubuntu/+source/pptpd/+bug/1571295/+attachment/4703422/+files/v3-fix-1571295-pptpd-conf-wrong-place.debdiff

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1571295

Title:
  pptpd module config loaded at wrong location

Status in pptpd package in Ubuntu:
  Fix Released
Status in pptpd source package in Xenial:
  Triaged
Status in pptpd package in Debian:
  Fix Released

Bug description:
  [Impact]

   * pptpd config is ignored (module not loaded)
   * update-initramfs shows a lot of errors on evey update (e.g. on every 
     kernel/dkms change)

  [Test Case]

  * Spawn xenial container and trigger bug
  apt-get install pptpd
  apt-get install linux-image-generic
    [...]
    libkmod: ERROR ../libkmod/libkmod-config.c:635 kmod_config_parse: /etc/modprobe.d/pptpd.conf line 1: ignoring bad line starting with 'nf_nat_pptp'
    libkmod: ERROR ../libkmod/libkmod-config.c:635 kmod_config_parse: /etc/modprobe.d/pptpd.conf line 1: ignoring bad line starting with 'nf_nat_pptp'
    [...]
  update-initramfs -u
    [...]
    libkmod: ERROR ../libkmod/libkmod-config.c:635 kmod_config_parse: /etc/modprobe.d/pptpd.conf line 1: ignoring bad line starting with 'nf_nat_pptp'
    libkmod: ERROR ../libkmod/libkmod-config.c:635 kmod_config_parse: /etc/modprobe.d/pptpd.conf line 1: ignoring bad line starting with 'nf_nat_pptp'
    [...]
  * Issue is now verified, so enable proposed and update
  * https://wiki.ubuntu.com/Testing/EnableProposed
  apt-cache policy pptpd
    Installed: 1.4.0-7
    Candidate: 1.4.0-7ubuntu0.1
  apt-get upgrade
  update-initramfs -u
    (now without issues)

  [Regression Potential]

   * Some guides in the internet had various workarounds to avoid the issue 
     of this config being ignored. The transition path added by the fix 
     worked with the workarounds I found. But there could be other solutions 
     which might start to break after the update. But OTOH it should be the 
     rare case of a rarely used tool - the fix will help much more users.

  [Other Info]
   * now Yakkety upload in this bug as it was "already there" due to 1.4.0-9 
     being merged already.



  
  libkmod: ERROR ../libkmod/libkmod-config.c:635 kmod_config_parse: /etc/modprobe.d/pptpd.conf line 1: ignoring bad line starting with 'nf_nat_pptp'

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/pptpd/+bug/1571295/+subscriptions