[Bug 1527460] Re: fwts PCIe ASPM tests are throwing Segmentation fault
Daniel Holbach
daniel.holbach at ubuntu.com
Mon Jan 4 09:37:47 UTC 2016
** Description changed:
Problem Description
===================
while running fwts Test in Firestone system on ubuntu14.04.3(3.19.0-25-generic) Failed
Steps to Reproduce
===================
- 1- Install Firestone system with ubuntu14.04.3(3.19.0-25-generic)
- 2-install fwts user space tool
- 3- run test
-
+ 1- Install Firestone system with ubuntu14.04.3(3.19.0-25-generic)
+ 2-install fwts user space tool
+ 3- run test
LOG:
===========
root at system :~# fwts --batch --interactive --power-states
Running 14 tests, results appended to results.log
- Test: Gather kernel system information.
- Gather kernel signature. 1 info only
- Gather kernel system information. 1 info only
- Gather kernel boot command line. 1 info only
- Gather ACPI driver version. 1 info only
- Test: Scan kernel log for Oopses.
- Kernel log oops check. 2 passed
- Test: Scan kernel log for errors and warnings.
- Kernel log error check. 1 passed
- Test: General ACPI information test.
- Determine Kernel ACPI version. 1 info only
- Determine machine's ACPI version.
- Determine AML compiler. 1 info only
- Test: UEFI secure boot test.
- Test aborted..
- Test: Test firmware has set PCI Express MaxReadReq to a higher value on n..
- Test firmware settings MaxReadReq for PCI Express de.. 1 passed
- Test: PCIe ASPM test.
+ Test: Gather kernel system information.
+ Gather kernel signature. 1 info only
+ Gather kernel system information. 1 info only
+ Gather kernel boot command line. 1 info only
+ Gather ACPI driver version. 1 info only
+ Test: Scan kernel log for Oopses.
+ Kernel log oops check. 2 passed
+ Test: Scan kernel log for errors and warnings.
+ Kernel log error check. 1 passed
+ Test: General ACPI information test.
+ Determine Kernel ACPI version. 1 info only
+ Determine machine's ACPI version.
+ Determine AML compiler. 1 info only
+ Test: UEFI secure boot test.
+ Test aborted..
+ Test: Test firmware has set PCI Express MaxReadReq to a higher value on n..
+ Test firmware settings MaxReadReq for PCI Express de.. 1 passed
+ Test: PCIe ASPM test.
Segmentation faultest. : 42.9% /
root at system:~#
- Regards
- Praveen
+
+
+ [SRU Justification][Trusty]
+
+ fwts segfaults because the ASPM test on this machine is returning no
+ ACPI tables and the test is not checking for a NULL table and hence
+ dereferencing it causing the segfault While debugging this I also
+ noticed that if /dev/mem is not available then two /dev/mem mmaps may
+ also cause a segfault, so I've added fixes for this too.
+
+ [Fix]
+ Upstream fix 9992dcca169282ab967177cc8bdac94eee66c93
+ https://lists.ubuntu.com/archives/fwts-devel/2015-December/007215.html
+ https://lists.ubuntu.com/archives/fwts-devel/2015-December/007217.html
+
+ [Testcase]
+ Run fwts on a system without ACPI tables. Will segfault. With the fix, it runs w/o a segfault
--
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1527460
Title:
fwts PCIe ASPM tests are throwing Segmentation fault
Status in fwts package in Ubuntu:
In Progress
Bug description:
Problem Description
===================
while running fwts Test in Firestone system on ubuntu14.04.3(3.19.0-25-generic) Failed
Steps to Reproduce
===================
1- Install Firestone system with ubuntu14.04.3(3.19.0-25-generic)
2-install fwts user space tool
3- run test
LOG:
===========
root at system :~# fwts --batch --interactive --power-states
Running 14 tests, results appended to results.log
Test: Gather kernel system information.
Gather kernel signature. 1 info only
Gather kernel system information. 1 info only
Gather kernel boot command line. 1 info only
Gather ACPI driver version. 1 info only
Test: Scan kernel log for Oopses.
Kernel log oops check. 2 passed
Test: Scan kernel log for errors and warnings.
Kernel log error check. 1 passed
Test: General ACPI information test.
Determine Kernel ACPI version. 1 info only
Determine machine's ACPI version.
Determine AML compiler. 1 info only
Test: UEFI secure boot test.
Test aborted..
Test: Test firmware has set PCI Express MaxReadReq to a higher value on n..
Test firmware settings MaxReadReq for PCI Express de.. 1 passed
Test: PCIe ASPM test.
Segmentation faultest. : 42.9% /
root at system:~#
[SRU Justification][Trusty]
fwts segfaults because the ASPM test on this machine is returning no
ACPI tables and the test is not checking for a NULL table and hence
dereferencing it causing the segfault While debugging this I also
noticed that if /dev/mem is not available then two /dev/mem mmaps may
also cause a segfault, so I've added fixes for this too.
[Fix]
Upstream fix 9992dcca169282ab967177cc8bdac94eee66c93
https://lists.ubuntu.com/archives/fwts-devel/2015-December/007215.html
https://lists.ubuntu.com/archives/fwts-devel/2015-December/007217.html
[Testcase]
Run fwts on a system without ACPI tables. Will segfault. With the fix, it runs w/o a segfault
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/fwts/+bug/1527460/+subscriptions
More information about the Ubuntu-sponsors
mailing list