[Merge] lp:~ubuntu-mate-dev/compiz/marco-gsettings into lp:compiz

Marco Trevisan (Treviño) mail at 3v1n0.net
Tue Feb 2 14:50:23 UTC 2016


Looks fine, maybe you should add this check to a function to avoid repetitions?

if (priv->marco && session && strlen (session) && strcasecmp (session, "MATE") == 0)

Also no need to use strlen, strcasecmp would stop anyway at first check (or you might do "session[0] != '\0'", for empty-string checks, but it's not needed here).
-- 
https://code.launchpad.net/~ubuntu-mate-dev/compiz/marco-gsettings/+merge/282882
Your team Ubuntu Sponsors Team is requested to review the proposed merge of lp:~ubuntu-mate-dev/compiz/marco-gsettings into lp:compiz.



More information about the Ubuntu-sponsors mailing list