[Bug 1479014] Re: "Cancel", "Next", and "Sign In" functioning incorrectly on login or locked screen in "Sign In?" section

[Tim]

This has been fixed in wily, I don't think its a good idea to  sru 7
different patches into vivid at this late stage in the cycle (it will be
EOL in a few months). For the most part these are largely cosmetic fixes
and clearly some of these patches caused regressions, hence the large
number of patches, so its not clear if other patches have been missed.

** Changed in: gnome-shell (Ubuntu Vivid)
       Status: Triaged => Won't Fix

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1479014

Title:
  "Cancel", "Next", and "Sign In" functioning incorrectly on login or
  locked screen in "Sign In?" section

Status in Ubuntu GNOME:
  Triaged
Status in gnome-shell package in Ubuntu:
  Fix Released
Status in gnome-shell source package in Vivid:
  Won't Fix
Status in gnome-shell source package in Wily:
  Fix Released

Bug description:
  [Impact]

  There are five patches in this one fix. So there are five bugs which
  are fixed:

  - Bug [1]: If the "Next" button ever gets set to "Sign In", it won't
  get reset to next until the next question asked by pam.

  - Bug [2]: Normally the user isn't allowed to proceed passed
  the username question until they've filled it in.
  To ensure this, the authprompt code desensitizes
  the next button when the number of characters change to
  zero.
  Unfortunately it fails to desensitize the next button
  up front when the entry starts out empty.

  - Bug [3]: Users are not allowed to cancel if the verification has not
  started yet and they are typing in their username.

  - Bug [4]: If the authPrompt gets reset for some other reason in the
  interim, this would mean that we don't fade the authentication prompt
  back in when it is needed.

  - Bug [5]: The user session will crash when the login screen is
  reactivated due to the fact that the previous the user verifier has
  not been cleared.

  - Bug [6]: (LP: #752220) We currently only cancel the user verifier on
  reset if verifying, but that means we don't properly cancel it when
  asking for a username at the "Not Listed" screen.

  These are rather important things to be fixed as they make the login
  process more confusing and difficult.

  How the bugs are fixed:

  - Bug [1] fix: Reset "Next" button to "Next" when asking for username.

  - Bug [2] fix: Disallow the user to press "Next" when the username
  field is empty up front.

  - Bug [3] fix: authPrompt no longer ignores the request to cancel
  before a user has started verification and is still typing in their
  username.

  - Bug [4] fix: loginDialog now only skips the fade-in if we have
  already faded-in. It now also only skips resetting if we have already
  reset.

  - Bug [5] fix: We now make sure that once the user verifier has
  completed its job (of user verification) that it gets cleared so that
  it does not get in the way later.

  - Bug [6] fix: We now unconditionally cancel if the user verifier has
  been reset.

  [Test Case]

  - Reproduce Bug [1]:

  On the first login screen (or log out - not lock), click "Sign In?",
  then before doing anything else click "Sign In", if the button allows
  you to press it and is not greyed out, then you have successfully
  reproduced this bug.

  - Reproduce Bug [2]:

  On the locked screen click "Sign In?", then before doing anything else
  press "Cancel". If nothing happens, you have successfully reproduced
  this bug.

  - Reproduce Bug [3]:

  On the locked screen click "Sign In?", then in the username field,
  start entering your username (or any text), then instead of pressing
  "Next", press "Cancel", if nothing happens then you have successfully
  reproduced this bug.

  - Reproduce Bug [4]:

  Go to the login screen (or locked screen), reset the authentication
  prompt before you have reached "VERIFICATION_SUCCEEDED", and if you
  see that the prompt does not fade back in, then you have successfully
  reproduced this bug.

   - Reproduce Bug [5]:

  After you have logged in, go back to the login screen, if the user
  session crashes, then you have successfully reproduced this bug.

  - Reproduce Bug [6]:

  On the login screen go to the "Not Listed" section, and then attempt
  to cancel. If it does not let you, then you have successfully
  reproduced this bug.

  [Regression Potential]

  As these patches have already been put to practical use in the
  upstream version, and the patches which have been put to use in this
  version, have originated from those patches, I would say that the risk
  of regression is minimal.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-gnome/+bug/1479014/+subscriptions