[Bug 1477198] Re: Stop doesn't work on 14.04 (start-stop-daemon --pid not supported)

[Chris J Arges]

Hello Jorge, or anyone else affected,

Accepted haproxy into wily-proposed. The package will build now and be
available at
https://launchpad.net/ubuntu/+source/haproxy/1.5.14-1ubuntu0.15.10.1 in
a few hours, and then in the -proposed repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to
enable and use -proposed.  Your feedback will aid us getting this update
out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested, and change the tag
from verification-needed to verification-done. If it does not fix the
bug for you, please add a comment stating that, and change the tag to
verification-failed.  In either case, details of your testing will help
us make a better decision.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance!

** Changed in: haproxy (Ubuntu Wily)
       Status: In Progress => Fix Committed

** Tags removed: verification-done

** Tags added: verification-needed

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1477198

Title:
  Stop doesn't work on 14.04 (start-stop-daemon --pid not supported)

Status in Ubuntu Cloud Archive:
  Invalid
Status in Ubuntu Cloud Archive kilo series:
  Invalid
Status in Ubuntu Cloud Archive liberty series:
  In Progress
Status in haproxy package in Ubuntu:
  Fix Released
Status in haproxy source package in Trusty:
  Fix Released
Status in haproxy source package in Wily:
  Fix Committed
Status in haproxy source package in Xenial:
  Fix Released
Status in haproxy package in Debian:
  New

Bug description:
  [Description]

  The stop method is not working properly. I removed the --oknodo &&
  --quiet and is returning (No /usr/sbin/haproxy found running; none
  killed)

  I think this is a regression caused by the incorporation of this lines
  on the stop method:

  +	for pid in $(cat $PIDFILE); do
  +		start-stop-daemon --quiet --oknodo --stop \
  +			--retry 5 --pid $pid --exec $HAPROXY || ret=$?

  root at juju-machine-1-lxc-0:~# service haproxy status
  haproxy is running.
  root at juju-machine-1-lxc-0:~# ps -ef| grep haproxy
  haproxy     1269       1  0 14:33 ?        00:00:00 /usr/sbin/haproxy -f /etc/haproxy/haproxy.cfg -D -p /var/run/haproxy.pid
  root        1513     906  0 14:33 pts/6    00:00:00 grep --color=auto haproxy
  root at juju-machine-1-lxc-0:~# service haproxy restart
   * Restarting haproxy haproxy
     ...done.
  root at juju-machine-1-lxc-0:~# ps -ef| grep haproxy
  haproxy     1269       1  0 14:33 ?        00:00:00 /usr/sbin/haproxy -f /etc/haproxy/haproxy.cfg -D -p /var/run/haproxy.pid
  haproxy     2169       1  0 14:33 ?        00:00:00 /usr/sbin/haproxy -f /etc/haproxy/haproxy.cfg -D -p /var/run/haproxy.pid
  root        2277     906  0 14:33 pts/6    00:00:00 grep --color=auto haproxy
  root at juju-machine-1-lxc-0:~# service haproxy restart
   * Restarting haproxy haproxy
     ...done.
  root at juju-machine-1-lxc-0:~# ps -ef| grep haproxy
  haproxy     1269       1  0 14:33 ?        00:00:00 /usr/sbin/haproxy -f /etc/haproxy/haproxy.cfg -D -p /var/run/haproxy.pid
  haproxy     2169       1  0 14:33 ?        00:00:00 /usr/sbin/haproxy -f /etc/haproxy/haproxy.cfg -D -p /var/run/haproxy.pid
  haproxy     2505       1  0 14:33 ?        00:00:00 /usr/sbin/haproxy -f /etc/haproxy/haproxy.cfg -D -p /var/run/haproxy.pid
  root        2523     906  0 14:33 pts/6    00:00:00 grep --color=auto haproxy
  root at juju-machine-1-lxc-0:~# service haproxy stop
   * Stopping haproxy haproxy
     ...done.
  root at juju-machine-1-lxc-0:~# ps -ef| grep haproxy
  haproxy     1269       1  0 14:33 ?        00:00:00 /usr/sbin/haproxy -f /etc/haproxy/haproxy.cfg -D -p /var/run/haproxy.pid
  haproxy     2169       1  0 14:33 ?        00:00:00 /usr/sbin/haproxy -f /etc/haproxy/haproxy.cfg -D -p /var/run/haproxy.pid
  haproxy     2505       1  0 14:33 ?        00:00:00 /usr/sbin/haproxy -f /etc/haproxy/haproxy.cfg -D -p /var/run/haproxy.pid
  root        2584     906  0 14:34 pts/6    00:00:00 grep --color=auto haproxy
  root at juju-machine-1-lxc-0:~# service haproxy start
   * Starting haproxy haproxy
     ...done.
  root at juju-machine-1-lxc-0:~# ps -ef| grep haproxy
  haproxy     1269       1  0 14:33 ?        00:00:00 /usr/sbin/haproxy -f /etc/haproxy/haproxy.cfg -D -p /var/run/haproxy.pid
  haproxy     2169       1  0 14:33 ?        00:00:00 /usr/sbin/haproxy -f /etc/haproxy/haproxy.cfg -D -p /var/run/haproxy.pid
  haproxy     2505       1  0 14:33 ?        00:00:00 /usr/sbin/haproxy -f /etc/haproxy/haproxy.cfg -D -p /var/run/haproxy.pid
  haproxy     2591       1  0 14:34 ?        00:00:00 /usr/sbin/haproxy -f /etc/haproxy/haproxy.cfg -D -p /var/run/haproxy.pid
  root        2610     906  0 14:34 pts/6    00:00:00 grep --color=auto haproxy

  [Impact]

  - 'service stop/restart' doesn't works properly.

  [Test Case]

  - Install latest haproxy package.
  - Run service haproxy restart
   * Restarting haproxy haproxy
     ...done.
  root at juju-machine-1-lxc-0:~# ps -ef| grep haproxy
  haproxy     1269       1  0 14:33 ?        00:00:00 /usr/sbin/haproxy -f /etc/haproxy/haproxy.cfg -D -p /var/run/haproxy.pid
  haproxy     2169       1  0 14:33 ?        00:00:00 /usr/sbin/haproxy -f /etc/haproxy/haproxy.cfg -D -p /var/run/haproxy.pid

  - Run service haproxy stop

  root at juju-machine-1-lxc-0:~# service haproxy stop
   * Stopping haproxy haproxy
     ...done.
  root at juju-machine-1-lxc-0:~# ps -ef| grep haproxy
  haproxy     1269       1  0 14:33 ?        00:00:00 /usr/sbin/haproxy -f /etc/haproxy/haproxy.cfg -D -p /var/run/haproxy.pid
  haproxy     2169       1  0 14:33 ?        00:00:00 /usr/sbin/haproxy -f /etc/haproxy/haproxy.cfg -D -p /var/run/haproxy.pid

  [Other info]

  Related bugs:
   * bug 1481737:  HAProxy init script does not work correctly with nbproc configuration option

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloud-archive/+bug/1477198/+subscriptions