[Bug 1462495] Re: [sru] Init file does not respect the LSB spec.

[Brian Murray]

Hello Jorge, or anyone else affected,

Accepted haproxy into utopic-proposed. The package will build now and be
available at https://launchpad.net/ubuntu/+source/haproxy/1.5.4-1ubuntu2
in a few hours, and then in the -proposed repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to
enable and use -proposed.  Your feedback will aid us getting this update
out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested, and change the tag
from verification-needed to verification-done. If it does not fix the
bug for you, please add a comment stating that, and change the tag to
verification-failed.  In either case, details of your testing will help
us make a better decision.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance!

** Changed in: haproxy (Ubuntu Utopic)
       Status: In Progress => Fix Committed

** Tags added: verification-needed

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1462495

Title:
  [sru] Init file does not respect the LSB spec.

Status in haproxy package in Ubuntu:
  Fix Released
Status in haproxy source package in Trusty:
  In Progress
Status in haproxy source package in Utopic:
  Fix Committed

Bug description:
  [Environment]

  Trusty 14.04.2

  [Description]

  Looking in the /etc/init.d/haproxy script, particularly the stop
  method, is returning 4 in case of the pidfile doesn't exists.

   /bin/kill $pid || return 4.

  According to the spec that means 'insufficient privileges' which is not correct. This is causing pacemaker and other
  system monitoring tools to fail because it doesn't complains with LSB.

  An example:

  Jun  2 12:52:13 glance02 crmd[2518]:   notice: process_lrm_event: glance02-res_glance_haproxy_monitor_5000:22 [ haproxy dead, but /var/run/haproxy.pid exists.\n ]
  Jun  2 12:52:13 glance02 crmd[2518]:   notice: process_lrm_event: LRM operation res_glance_haproxy_stop_0 (call=33, rc=4, cib-update=19, confirmed=true) insufficient privileges

  Reference:

  haproxy_stop()
  {
      if [ ! -f $PIDFILE ] ; then
          # This is a success according to LSB
          return 0
      fi
      for pid in $(cat $PIDFILE) ; do
          /bin/kill $pid || return 4
      done
      rm -f $PIDFILE
      return 0
  }

  [Impact]

  * Pacemaker or any other system monitoring tool that relies
  on a proper exit code could fail as this doesn't complains with LSB.

  [Test Case]

  * Kill manually the process and then stop haproxy on Trusty/Utopic and
  check exit code.

  $ sudo killall -9 haproxy
  $ sudo service haproxy stop | echo $?

  [Regression Potential]

  * If any application or shell script is relying on a wrong exit code
  4 , then it could be affected by this change.

  [Proposed solution]

  Backport the current devel (wily) init.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/haproxy/+bug/1462495/+subscriptions