[Bug 1432062] Re: multipath-tools-boot: support booting without user_friendly_names on devices with spaces in identifiers

[Scott Moser]

Hi,
Attached to bug 1371634 i added a script that shows a general issue with kpartx being called on files with spaces in them.
Does that seem like a bug that should also be fixed?

it shows itself with:
$ img="/tmp/my.img"; spacename="/dev/my space name";
$ truncate --size=1G "$img"
$ echo "2048," | sfdisk --force "$img" --unit S
$ lodev=$(sudo losetup --find --show "$img")
$ echo $lodev
/dev/loop0
$ sudo ln -sf "$lodev" "$spacename"
$ ls -l $lodev "$spacename"
brw-rw---- 1 root disk 7, 0 Jun  4 09:25 /dev/loop0
lrwxrwxrwx 1 root root   10 Jun  4 09:25 /dev/my space name -> /dev/loop0

$ sudo kpartx -a -v "$spacename"
device-mapper: reload ioctl on my\x20space\x20name1 failed: Invalid argument
create/reload failed on my space name1
add map my space name1 (0:0): 0 2095104 linear /dev/my space name 2048

## then clean up
$ sudo losetup -d "$lodev"
$ sudo rm "$spacename" "$img"

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1432062

Title:
  multipath-tools-boot: support booting without user_friendly_names on
  devices with spaces in identifiers

Status in multipath-tools package in Ubuntu:
  Triaged

Bug description:
  If a system is not installed w/ multipath support (i.e., no disk-detect/multipath/enable=true), the /etc/multipath.conf file is not installed.
  If an user later installs multipath-tools-boot, it will enable the udev rules for multipath support.
  Those rules don't handle disk devices w/ spaces on their names/uuids/models very well..

  That's because of udev's SYMLINK command using spaces to separate
  multiple links, and the kernel sysfs/dm informing \x20 instead, which
  is not correctly interpreted by some commands, resulting in file not
  found errors, for example.

  Thus, the system fails to boot.

  There's no problem, however, if user_friendly_names is enabled in
  multipath.conf (which is enabled in the default multipath.conf from
  the installer, if it has multipath enabled).

  Notice it's an acceptable case to install w/out multipath support, and
  enable it later for booting.

  Disk devices w/ spaces in naming is not common over SAN/storage systems, but that happens often for conventional disks; for example:
  - IBM IPR  ( IBM     IPR-0   5DB6F40000000080 )
  - IBM VDASD ( AIX     VDASD           00c96f0700004c000000014bb8e713f0.14 )
  - QEMU HARDDISK ( QEMU QEMU HARDDISK <serial> )

  So, please, is it possible to ship the default multipath.conf (e.g.,
  from installer) w/ multipath-tools-boot?

  For users not to their systems failing to boot after installing
  multipath-tools-boot manually, after a non-multipath install.

  Related bugs:
   * bug 1371634: block devices appear twice

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/multipath-tools/+bug/1432062/+subscriptions