[Bug 1461082] [NEW] patch - fix crash with long one-line XML documents

Launchpad Bug Tracker 1461082 at bugs.launchpad.net
Tue Jun 2 16:18:59 UTC 2015


You have been subscribed to a public bug by Ubuntu Foundations Team Bug Bot (crichton):

[Impact]

When editing a long one-line document with some markup (e.g. XML) with
Pluma (or any other editor using gtksourceview2), you cannot delete a
selected portion of text because the editor will crash.

This has been reported upstream and fixed in [1], but the commit never
made it to GTK+2 version of gtksourceview.

So, I propose fixing it in current stable Ubuntu releases with the patch which fixes the crash for good.
The debdiffs for every stable release are in the attachments below.


[Test Case]

Steps to reproduce:

1. Open a long one-line XML document (e.g. [2]) with Pluma. Any other editor using gtksourceview2 will also fit I think.
2. Select a portion of text.
3. Press Backspace (or Delete) key.
4. Pluma crashes. The full backtrace is at [3].

If you're running Pluma from the command-line, you'll notice a warning:
GtkSourceView-CRITICAL **: Highlighting a single line took too much time, syntax highlighting will be disabled

That's the key. The library tries to invalidate the region when text is
deleted and the engine is disabled (i.e. syntax highlighting is off).


[Regression Potential]

After several months of testing the patch in Debian Jessie, I haven't
noticed any regressions.


[1] https://git.gnome.org/browse/gtksourceview/commit/?id=abef41da8c541c814bf631f69c92e0c431c610ad
[2] http://pastebin.com/nNdYzFXE
[3] http://pastebin.com/YgDT0iKh

** Affects: gtksourceview2 (Ubuntu)
     Importance: Undecided
         Status: New

** Affects: gtksourceview2 (Debian)
     Importance: Unknown
         Status: Confirmed


** Tags: patch precise trusty utopic vivid
-- 
patch - fix crash with long one-line XML documents
https://bugs.launchpad.net/bugs/1461082
You received this bug notification because you are a member of Ubuntu Sponsors Team, which is subscribed to the bug report.



More information about the Ubuntu-sponsors mailing list