[Bug 1413084] Re: cvsps chokes on servers that print more than one "M" response to "version" command

[Richard Hansen]

Attached is a script that can be used to test whether cvsps has been
fixed or not.

** Attachment added: "cvsps test script"
   https://bugs.launchpad.net/ubuntu/+source/cvsps/+bug/1413084/+attachment/4319685/+files/test-cvsps.sh

** Description changed:

- If the CVS server prints more than on "M" response line to the "version"
- command, cvsps prints "cvs_direct: protocol error reading version" and
- fails to read the repository.
+ [Impact]
+ 
+ If the CVS server prints more than one "M" response line to the
+ "version" command, cvsps (in --cvs-direct mode) prints "cvs_direct:
+ protocol error reading version" and fails to read the repository.
  
  For example, cvsps does not like the following exchange:
  
  Client: version
  Server: M Concurrent Versions System (CVS) 1.12.13 (client/server)
  Server: M with CVSACL Patch 1.2.5 (cvsacl.sourceforge.net)
  Server: ok
  
- I know that cvsps has been deprecated upstream in favor of cvs-fast-
- export, but it is still used by 'git cvsimport'.
+ (Note: cvsps has been deprecated upstream in favor of cvs-fast-export,
+ but it is still used by 'git cvsimport'.)
+ 
+ [Test Case]
+ 
+ Download and run the attached test script.  The output looks like this
+ if the installed version of cvsps has the bug:
+ 
+   cvs_direct initialized to CVSROOT /foo
+   cvs_direct: protocol error reading version
+   ERROR: cvsps does not appear to work with multi-line version strings
+ 
+ and it looks like this if the bug has been fixed:
+ 
+   cvs_direct initialized to CVSROOT /foo
+   test passed
+ 
+ [Regression Potential]
+ 
+ No immediately obvious risks.

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1413084

Title:
  cvsps chokes on servers that print more than one "M" response to
  "version" command

Status in cvsps package in Ubuntu:
  Fix Released
Status in cvsps package in Debian:
  New

Bug description:
  [Impact]

  If the CVS server prints more than one "M" response line to the
  "version" command, cvsps (in --cvs-direct mode) prints "cvs_direct:
  protocol error reading version" and fails to read the repository.

  For example, cvsps does not like the following exchange:

  Client: version
  Server: M Concurrent Versions System (CVS) 1.12.13 (client/server)
  Server: M with CVSACL Patch 1.2.5 (cvsacl.sourceforge.net)
  Server: ok

  (Note: cvsps has been deprecated upstream in favor of cvs-fast-export,
  but it is still used by 'git cvsimport'.)

  [Test Case]

  Download and run the attached test script.  The output looks like this
  if the installed version of cvsps has the bug:

    cvs_direct initialized to CVSROOT /foo
    cvs_direct: protocol error reading version
    ERROR: cvsps does not appear to work with multi-line version strings

  and it looks like this if the bug has been fixed:

    cvs_direct initialized to CVSROOT /foo
    test passed

  [Regression Potential]

  No immediately obvious risks.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/cvsps/+bug/1413084/+subscriptions