[Bug 1521366] Re: Compiz fails to build tests with recent g++ and xorg-gtest

[Bug Watch Updater]

Launchpad has imported 1 comments from the remote bug at
https://bugs.freedesktop.org/show_bug.cgi?id=93191.

If you reply to an imported comment from within Launchpad, your comment
will be sent to the remote bug automatically. Read more about
Launchpad's inter-bugtracker facilities at
https://help.launchpad.net/InterBugTracking.

------------------------------------------------------------------------
On 2015-12-01T09:48:05+00:00 Marco Trevisan (Treviño) wrote:

Created attachment 120222
xorg-gtest.pc.in-Fix-CPPflags-escaping-for-string-pa.patch

As per the pkg-config fix for Bug 67904, xorg-gtest CPPflags aren't
properly escaped anymore.

old_behavior $ pkg-config --variable=CPPflags xorg-gtest 
-I/usr/include -I/usr/include/xorg -I/usr/src/xorg-gtest -DDUMMY_CONF_PATH=\"/usr/share/xorg/gtest/dummy.conf\" -DLOGFILE_DIR=\"/tmp\"


new_behavior $ pkg-config --variable=CPPflags xorg-gtest 
-I/usr/include -I/usr/include/xorg -I/usr/src/xorg-gtest -DDUMMY_CONF_PATH=/usr/share/xorg/gtest/dummy.conf -DLOGFILE_DIR=/tmp

Attached is a patch that fixes this

Reply at: https://bugs.launchpad.net/ubuntu/+source/xorg-
gtest/+bug/1521366/comments/3


** Changed in: xorg-gtest
       Status: Unknown => Confirmed

** Changed in: xorg-gtest
   Importance: Unknown => Medium

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1521366

Title:
  Compiz fails to build tests with recent g++ and xorg-gtest

Status in Xorg-gtest:
  Confirmed
Status in xorg-gtest package in Ubuntu:
  In Progress
Status in xorg-gtest source package in Xenial:
  In Progress

Bug description:
  When compiling with g++ 5 xorg-gtest fails because of the CPPflags
  defined in xorg-gtest.pc

  Compiz FTB in /usr/src/xorg-gtest/src/environment.cpp: In constructor 'xorg::testing::Environment::Private::Private()':
  <command-line>:0:17: error: expected primary-expression before '/' token
  /usr/src/xorg-gtest/src/environment.cpp:48:28: note: in expansion of macro 'DUMMY_CONF_PATH'
     Private() : path_to_conf(DUMMY_CONF_PATH),
                              ^
  <command-line>:0:18: error: 'usr' was not declared in this scope
  /usr/src/xorg-gtest/src/environment.cpp:48:28: note: in expansion of macro 'DUMMY_CONF_PATH'
     Private() : path_to_conf(DUMMY_CONF_PATH),
                              ^
  <command-line>:0:22: error: 'share' was not declared in this scope
  /usr/src/xorg-gtest/src/environment.cpp:48:28: note: in expansion of macro 'DUMMY_CONF_PATH'
     Private() : path_to_conf(DUMMY_CONF_PATH),
                              ^
  <command-line>:0:32: error: expected primary-expression before '/' token
  /usr/src/xorg-gtest/src/environment.cpp:48:28: note: in expansion of macro 'DUMMY_CONF_PATH'
     Private() : path_to_conf(DUMMY_CONF_PATH),
                              ^
  <command-line>:0:33: error: 'gtest' was not declared in this scope
  /usr/src/xorg-gtest/src/environment.cpp:48:28: note: in expansion of macro 'DUMMY_CONF_PATH'
     Private() : path_to_conf(DUMMY_CONF_PATH),
                              ^
  <command-line>:0:39: error: 'dummy' was not declared in this scope
  /usr/src/xorg-gtest/src/environment.cpp:48:28: note: in expansion of macro 'DUMMY_CONF_PATH'
     Private() : path_to_conf(DUMMY_CONF_PATH),
                              ^
  <command-line>:0:13: error: expected primary-expression before '/' token
  /usr/src/xorg-gtest/src/defines.h:4:30: note: in expansion of macro 'LOGFILE_DIR'
   #define DEFAULT_XORG_LOGFILE LOGFILE_DIR "/Xorg.GTest.log"
                                ^
  /usr/src/xorg-gtest/src/environment.cpp:49:32: note: in expansion of macro 'DEFAULT_XORG_LOGFILE'
                 path_to_log_file(DEFAULT_XORG_LOGFILE),
                                  ^
  <command-line>:0:14: error: 'tmp' was not declared in this scope
  /usr/src/xorg-gtest/src/defines.h:4:30: note: in expansion of macro 'LOGFILE_DIR'
   #define DEFAULT_XORG_LOGFILE LOGFILE_DIR "/Xorg.GTest.log"
                                ^
  /usr/src/xorg-gtest/src/environment.cpp:49:32: note: in expansion of macro 'DEFAULT_XORG_LOGFILE'
                 path_to_log_file(DEFAULT_XORG_LOGFILE),

To manage notifications about this bug go to:
https://bugs.launchpad.net/xorg-gtest/+bug/1521366/+subscriptions