[Merge] lp:~nobuto/ubuntu/vivid/unzip/fallback-encoding into lp:ubuntu/unzip

Nobuto Murata nobuto at nobuto-murata.org
Fri Apr 3 18:30:21 UTC 2015


You have been requested to review the proposed merge of lp:~nobuto/ubuntu/vivid/unzip/fallback-encoding into lp:ubuntu/unzip.

For more details, see:
https://code.launchpad.net/~nobuto/ubuntu/vivid/unzip/fallback-encoding/+merge/249644

This branch adds default charsets handling for Windows archives in CJKV+th locale, inspired by Ubuntu Kylin way.

As a result of bug #580961, two options have been added as Ubuntu patch.
> -O CHARSET  specify a character encoding for DOS, Windows and OS/2 archives
> -I CHARSET  specify a character encoding for UNIX and other archives

Then Ubuntu Kylin added default encoding as environment variables for their distribution.
http://bazaar.launchpad.net/~ubuntukylin-members/ubuntukylin-default-settings/trunk/revision/171

Now as Ubuntu, we can go further by a better way:
 - per user settings by their locales instead of global settings
 - don't interfere in other locales by locale guard

I only add "-O", so no behavior change for zip files created on Ubuntu or other Linux/UNIX systems. This branch just handles zip file created on localized Windows system seamlessly.

charsets list is taken from:
https://msdn.microsoft.com/en-us/goglobal/bb964654
and
msdos/msdos.c in unzip package:
   1682     case 932:   /* Japanese */
   1683     case 949:   /* Korean */
   1684     case 936:   /* Chinese, simple */
   1685     case 950:   /* Chinese, traditional */
   1686     case 874:   /* Thai */
   1687     case 1258:  /* Vietnamese */


-- 
Your team Ubuntu Sponsors Team is requested to review the proposed merge of lp:~nobuto/ubuntu/vivid/unzip/fallback-encoding into lp:ubuntu/unzip.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 1841 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-sponsors/attachments/20150403/faa80594/attachment.diff>


More information about the Ubuntu-sponsors mailing list