[Bug 1347257] Re: Shouldn't add -Wformat-security and -Werror=format-security arguments if -Wno-format or -Wno-format-security is specified by the caller

[Matthias Klose]

** Description changed:

+ Proposing to backport this unchanged to trusty. The patch is attached
+ below in a comment. Verified that the additional parameters are not
+ added.
+ 
  Firefox currently fails to build in utopic with the following error:
  
  c++ -o hexdump.o -c -I../../dist/stl_wrappers -I../../dist/system_wrappers -include /build/buildd/firefox-32.0~b1+build1/config/gcc_hidden.h -DANDROID_SMP=0 -DLOG_NDEBUG=0 -D_GLIBCXX_OS_DEFINES -DHAVE_SYS_UIO_H -DFAKE_LOG_DEVICE -DMOZ_GLUE_IN_PROGRAM -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL  -DSTATIC_EXPORTABLE_JS_API -DNO_NSPR_10_SUPPORT -I/build/buildd/firefox-32.0~b1+build1/media/libstagefright -I. -I/build/buildd/firefox-32.0~b1+build1/media/libstagefright/binding/include -I/build/buildd/firefox-32.0~b1+build1/media/libstagefright/frameworks/av/include -I/build/buildd/firefox-32.0~b1+build1/media/libstagefright/frameworks/av/include/media/stagefright/foundation -I/build/buildd/firefox-32.0~b1+build1/media/libstagefright/frameworks/av/media/libstagefright/ -I/build/buildd/firefox-32.0~b1+build1/media/libstagefright/stubs/empty -I/build/buildd/firefox-32.0~b1+build1/media/libstagefright/stubs/include -I/build/buildd/firefox-32.0~b1+build1/media/libstagefright/stubs/include/media/stagefright/foundation -I/build/buildd/firefox-32.0~b1+build1/media/libstagefright/system/core/include -I../../dist/include  -I/build/buildd/firefox-32.0~b1+build1/obj-x86_64-linux-gnu/dist/include/nspr -I/build/buildd/firefox-32.0~b1+build1/obj-x86_64-linux-gnu/dist/include/nss  -I/build/buildd/firefox-32.0~b1+build1/obj-x86_64-linux-gnu/dist/include -I/build/buildd/firefox-32.0~b1+build1/modules/zlib/src    -fPIC   -DMOZILLA_CLIENT -include ../../mozilla-config.h -MD -MP -MF .deps/hexdump.o.pp  -Wall -Wpointer-arith -Woverloaded-virtual -Werror=return-type -Werror=int-to-pointer-cast -Wtype-limits -Wempty-body -Wsign-compare -Wno-invalid-offsetof -Wcast-align -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -std=gnu++0x -pthread -pipe  -DNDEBUG -DTRIMMED -g -Os -freorder-blocks  -fomit-frame-pointer -Wno-format -Wno-multichar -Wno-sign-compare -Wno-unused    /build/buildd/firefox-32.0~b1+build1/media/libstagefright/frameworks/av/media/libstagefright/foundation/hexdump.cpp
  cc1plus: error: -Wformat-security ignored without -Wformat [-Werror=format-security]
  cc1plus: some warnings being treated as errors
  /build/buildd/firefox-32.0~b1+build1/config/rules.mk:1001: recipe for target 'hexdump.o' failed
  make[6]: *** [hexdump.o] Error 1
  
  https://launchpadlibrarian.net/180524763/buildlog_ubuntu-utopic-
  amd64.firefox_32.0~b1%2Bbuild1-0ubuntu1_FAILEDTOBUILD.txt.gz
  
  Firefox is built with hardening-wrapper (including the format string
  hardening), but it specifies -Wno-format just for the code in this
  subdirectory - presumably because this is a third-party module

** Patch added: "backport for trusty"
   https://bugs.launchpad.net/ubuntu/+source/hardening-wrapper/+bug/1347257/+attachment/4229597/+files/hw.debdiff

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1347257

Title:
  Shouldn't add -Wformat-security and -Werror=format-security arguments
  if -Wno-format or -Wno-format-security is specified by the caller

Status in “hardening-wrapper” package in Ubuntu:
  Fix Released
Status in “hardening-wrapper” source package in Trusty:
  New

Bug description:
  Proposing to backport this unchanged to trusty. The patch is attached
  below in a comment. Verified that the additional parameters are not
  added.

  Firefox currently fails to build in utopic with the following error:

  c++ -o hexdump.o -c -I../../dist/stl_wrappers -I../../dist/system_wrappers -include /build/buildd/firefox-32.0~b1+build1/config/gcc_hidden.h -DANDROID_SMP=0 -DLOG_NDEBUG=0 -D_GLIBCXX_OS_DEFINES -DHAVE_SYS_UIO_H -DFAKE_LOG_DEVICE -DMOZ_GLUE_IN_PROGRAM -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL  -DSTATIC_EXPORTABLE_JS_API -DNO_NSPR_10_SUPPORT -I/build/buildd/firefox-32.0~b1+build1/media/libstagefright -I. -I/build/buildd/firefox-32.0~b1+build1/media/libstagefright/binding/include -I/build/buildd/firefox-32.0~b1+build1/media/libstagefright/frameworks/av/include -I/build/buildd/firefox-32.0~b1+build1/media/libstagefright/frameworks/av/include/media/stagefright/foundation -I/build/buildd/firefox-32.0~b1+build1/media/libstagefright/frameworks/av/media/libstagefright/ -I/build/buildd/firefox-32.0~b1+build1/media/libstagefright/stubs/empty -I/build/buildd/firefox-32.0~b1+build1/media/libstagefright/stubs/include -I/build/buildd/firefox-32.0~b1+build1/media/libstagefright/stubs/include/media/stagefright/foundation -I/build/buildd/firefox-32.0~b1+build1/media/libstagefright/system/core/include -I../../dist/include  -I/build/buildd/firefox-32.0~b1+build1/obj-x86_64-linux-gnu/dist/include/nspr -I/build/buildd/firefox-32.0~b1+build1/obj-x86_64-linux-gnu/dist/include/nss  -I/build/buildd/firefox-32.0~b1+build1/obj-x86_64-linux-gnu/dist/include -I/build/buildd/firefox-32.0~b1+build1/modules/zlib/src    -fPIC   -DMOZILLA_CLIENT -include ../../mozilla-config.h -MD -MP -MF .deps/hexdump.o.pp  -Wall -Wpointer-arith -Woverloaded-virtual -Werror=return-type -Werror=int-to-pointer-cast -Wtype-limits -Wempty-body -Wsign-compare -Wno-invalid-offsetof -Wcast-align -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -std=gnu++0x -pthread -pipe  -DNDEBUG -DTRIMMED -g -Os -freorder-blocks  -fomit-frame-pointer -Wno-format -Wno-multichar -Wno-sign-compare -Wno-unused    /build/buildd/firefox-32.0~b1+build1/media/libstagefright/frameworks/av/media/libstagefright/foundation/hexdump.cpp
  cc1plus: error: -Wformat-security ignored without -Wformat [-Werror=format-security]
  cc1plus: some warnings being treated as errors
  /build/buildd/firefox-32.0~b1+build1/config/rules.mk:1001: recipe for target 'hexdump.o' failed
  make[6]: *** [hexdump.o] Error 1

  https://launchpadlibrarian.net/180524763/buildlog_ubuntu-utopic-
  amd64.firefox_32.0~b1%2Bbuild1-0ubuntu1_FAILEDTOBUILD.txt.gz

  Firefox is built with hardening-wrapper (including the format string
  hardening), but it specifies -Wno-format just for the code in this
  subdirectory - presumably because this is a third-party module

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/hardening-wrapper/+bug/1347257/+subscriptions