[Bug 1306629] Re: [SRU] SDL_syswm.h can't find mir_toolkit/mir_client_library.h

[Martin Pitt]

Utopic fix uploaded.

** Also affects: libsdl2 (Ubuntu Utopic)
   Importance: High
     Assignee: Brandon Schaefer (brandontschaefer)
       Status: Triaged

** Also affects: libsdl2 (Ubuntu Trusty)
   Importance: Undecided
       Status: New

** Changed in: libsdl2 (Ubuntu Trusty)
    Milestone: None => trusty-updates

** Changed in: libsdl2 (Ubuntu Utopic)
    Milestone: trusty-updates => None

** Changed in: libsdl2 (Ubuntu Utopic)
       Status: Triaged => Fix Committed

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1306629

Title:
  [SRU] SDL_syswm.h can't find mir_toolkit/mir_client_library.h

Status in Mir:
  Invalid
Status in “libsdl2” package in Ubuntu:
  Fix Committed
Status in “libsdl2” source package in Trusty:
  In Progress
Status in “libsdl2” source package in Utopic:
  Fix Committed

Bug description:
  I believe something is wrong with MIR support. A daily build of openmw
  just failed with:

  /usr/include/SDL2/SDL_syswm.h:97:44: fatal error: mir_toolkit/mir_client_library.h: No such file or directory
   #include <mir_toolkit/mir_client_library.h>

  In SDL_syswm.h:
  #if defined(SDL_VIDEO_DRIVER_MIR)
  #include <mir_toolkit/mir_client_library.h>
  #endif

  the file is:
  /usr/include/mirclient/mir_toolkit/mir_client_library.h
  http://packages.ubuntu.com/search?searchon=contents&keywords=mir_client_library.h&mode=exactfilename&suite=trusty&arch=any

  openmw buildlog:
  https://launchpadlibrarian.net/172588668/buildlog_ubuntu-trusty-i386.openmw_0.29%2Bgit20140411.77-0~ubuntu14.04.1_FAILEDTOBUILD.txt.gz

  it built successfully until the fix for bug #1295389 libsdl2 commit
  hit that enabled mir.

  Assigning "high" since it has the potentially to cause a large number
  of FTBFS in the archive.

  SRU Info:
  *Note* This patch has landed in libsdl2 upstream:
  https://hg.libsdl.org/SDL/rev/274017846e73

  1) The issue is we include mir_client_library.h, meaning everything that compiles sdl2 apps will need to include this as well. So we need to forward declare the structs so we don't need to include the mir header.
  2) A simple way to test the current Mir problem:
  http://paste.ubuntu.com/7271077/
  3) Regression potential: Very low, this is a 1 line patch, that adds the MIR_CFLAGS to the SDL_CFLAGS.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mir/+bug/1306629/+subscriptions