[Bug 1281066] Re: Needs to backport trusty's fix to handle duplicity's lockfile

[Michael Terry]

Uploaded to precise with one change:
+    Posix.system("/bin/rm -f " + Shell.quote(cache_dir) + "/*/lockfile.lock");
Became
+    Posix.system("/bin/rm -f " + Shell.quote(cache_dir) + "/" + Config.PACKAGE + "/*/lockfile.lock");

Because in trusty's deja-dup, cache_dir already contained PACKAGE, but
in precise's, it didn't.

Tested and worked for me combined with the duplicity SRU.

** Description changed:

  SRU justification :
  
  Duplicity implements a new lockfile that impacts deja-dup functionality.
  A fix to remove the lockfile is already commited upstream and in Trusty.
  The SRU is to make the fix available before duplicity's SRU is completed
  
  Impact :
  
- Without this SRU, duplicity's SRU for LP: #1266763 cannot be completed
- or it may result in regression issues
+ Without this SRU, duplicity's SRU for LP: #1266763 will cause errors
+ when backing up after having previously cancelled a backup.
  
  Fix :
  
  Remove the lockfile since concurrency is handled in DBUS in deja-dup
  
- Test Case : 
- TBD
+ Test Case :
+ 1) Start a backup
+ 2) Cancel it once it begins backing up
+ 3) Start the backup again
+ 
+ If you get an error right at the beginning of (3) about lockfiles, this
+ bug isn't fixed.  If the backup proceeds, it's fixed!
  
  Regression :
  
  None expected as it remove a file that is only present with newer
  versions of duplicity
  
  Description of the problem :
  
  See justification

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1281066

Title:
  Needs to backport trusty's fix to handle duplicity's lockfile

Status in “deja-dup” package in Ubuntu:
  Fix Committed
Status in “deja-dup” source package in Precise:
  In Progress
Status in “deja-dup” source package in Saucy:
  In Progress

Bug description:
  SRU justification :

  Duplicity implements a new lockfile that impacts deja-dup
  functionality. A fix to remove the lockfile is already commited
  upstream and in Trusty. The SRU is to make the fix available before
  duplicity's SRU is completed

  Impact :

  Without this SRU, duplicity's SRU for LP: #1266763 will cause errors
  when backing up after having previously cancelled a backup.

  Fix :

  Remove the lockfile since concurrency is handled in DBUS in deja-dup

  Test Case :
  1) Start a backup
  2) Cancel it once it begins backing up
  3) Start the backup again

  If you get an error right at the beginning of (3) about lockfiles,
  this bug isn't fixed.  If the backup proceeds, it's fixed!

  Regression :

  None expected as it remove a file that is only present with newer
  versions of duplicity

  Description of the problem :

  See justification

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/deja-dup/+bug/1281066/+subscriptions