[Bug 1320596] Re: Gramps unable to create or edit notes

[Brian Murray]

Hello Andrew, or anyone else affected,

Accepted gramps into trusty-proposed. The package will build now and be
available at http://launchpad.net/ubuntu/+source/gramps/4.0.3+dfsg-
2ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to
enable and use -proposed.  Your feedback will aid us getting this update
out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested, and change the tag
from verification-needed to verification-done. If it does not fix the
bug for you, please add a comment stating that, and change the tag to
verification-failed.  In either case, details of your testing will help
us make a better decision.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance!

** Changed in: gramps (Ubuntu Trusty)
       Status: Confirmed => Fix Committed

** Tags added: verification-needed

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1320596

Title:
  Gramps unable to create or edit notes

Status in “gramps” package in Ubuntu:
  Fix Released
Status in “gramps” source package in Trusty:
  Fix Committed

Bug description:
  Unable to edit or create notes in Gramps (Trusty).  This has worked
  prior to upgrading.

  This is the same as Debian Bug #747318, which has been marked as
  fixed.  I have applied the Debian patch to the Ubuntu version and the
  problem is fixed too.

  Since the file locations are slightly different than Debian, I have
  produced a patch for this.

  ProblemType: Bug
  DistroRelease: Ubuntu 14.04
  Package: gramps 4.0.3+dfsg-2 [modified: usr/lib/python2.7/dist-packages/gramps/gui/widgets/styledtexteditor.py]
  ProcVersionSignature: Ubuntu 3.13.0-24.47-generic 3.13.9
  Uname: Linux 3.13.0-24-generic x86_64
  ApportVersion: 2.14.1-0ubuntu3.1
  Architecture: amd64
  CurrentDesktop: KDE
  Date: Sun May 18 19:53:15 2014
  InstallationDate: Installed on 2012-12-23 (510 days ago)
  InstallationMedia: Kubuntu 12.10 "Quantal Quetzal" - Release amd64 (20121017.1)
  PackageArchitecture: all
  SourcePackage: gramps
  UpgradeStatus: Upgraded to trusty on 2014-04-25 (22 days ago)

  The following is an updated text justifying the SRU:
  Recommend an SRU (Stable Release Update)

  [Impact]

   This bug renders Gramps unusable for Genealogists because it is
  critical that you can save and edit notes whilst researching family
  trees. This is a very important function within Gramps.

   The patch is very small, and is taken directly from the development release (Utopic) which synced it from Debian:
  diff --git a/gramps/gui/widgets/styledtexteditor.py b/gramps/gui/widgets/styledtexteditor.py
  18 index a1c92db..d303404 100644
  19 --- a/gramps/gui/widgets/styledtexteditor.py
  20 +++ b/gramps/gui/widgets/styledtexteditor.py
  21 @@ -179,7 +179,8 @@ class StyledTextEditor(Gtk.TextView):
  22 self.textbuffer = UndoableStyledBuffer()
  23 self.textbuffer.connect('style-changed', self._on_buffer_style_changed)
  24 self.textbuffer.connect('changed', self._on_buffer_changed)
  25 - GObject.GObject.__init__(self, buffer=self.textbuffer)
  26 + GObject.GObject.__init__(self)
  27 + self.set_buffer(self.textbuffer)
  28
  29 st_cont = self.get_style_context()
  30 col = st_cont.lookup_color('link_color')

  [Test Case]

  Test Case 1 - Create a new note:
  1. Create a new Empty Family Tree.
  2. Goto "Notes" view using the left pane.
  3. Click on "+" to add a new note.
  4. Type something (e.g. "blabla") into the Text Field.
  5. Click "OK".
  > Instead of the note being saved, you get an error message "Cannot Save Note" and can only cancel the operation.

  Test Case 2 - Edit an existing note:
  1. Download the example file from:
  http://sourceforge.net/p/gramps/source/ci/maintenance/gramps40/~/tree/example/gramps/data.gramps
  2. From the "Family Tree" Menu, import the downloaded file.
  2. Goto "Notes" view using the left pane.
  3. Double-Click on one of the notes
  > Instead of seeing the text you saw in the preview, the note text field is empty. Typing in text is futile, when you click "OK" there is no error message, but what you added to the note is not saved and is not present in the Note View preview, only the old text.

  [Regression Potential]

   * There little risk of regression because the patch is minor.

   * The fix has been tested upstream, in Debian, and in the Ubuntu
  Development Release (Utopic).

   * In the worst case, user data could be erased if something is wrong
  in this area of the code that has not been detected so far. But the
  users would probably prefer to have this fix anyway, as they cannot
  really use Gramps as intended at the moment.

  [Other Info]

   * Nothing further to add.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/gramps/+bug/1320596/+subscriptions