[Bug 1339244] Re: Comparison of exit_status in run_custom_command is wrong

[Launchpad Bug Tracker]

This bug was fixed in the package gnome-settings-daemon -
3.8.6.1-0ubuntu15

---------------
gnome-settings-daemon (3.8.6.1-0ubuntu15) utopic; urgency=low

  * debian/patches/git_lp1339244.patch:
    - fix exit status check in gsd-input-helper.c (LP: #1339244)
 -- Michael Vogt <michael.vogt at ubuntu.com>   Thu, 10 Jul 2014 11:05:00 +0200

** Changed in: gnome-settings-daemon (Ubuntu)
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1339244

Title:
  Comparison of exit_status in run_custom_command is wrong

Status in “gnome-settings-daemon” package in Ubuntu:
  Fix Released
Status in “gnome-settings-daemon” source package in Trusty:
  New

Bug description:
  In file /plugins/common/gsd-input-helper.c in function
  run_custom_command the variable exit_status doesn't contain the exit
  status of the process, so the statement "return (exit_status == 1);"
  is wrong.

  The documentation (https://developer.gnome.org/glib/stable/glib-Spawning-Processes.html#g-spawn-sync) says:
  exit_status    return location for child exit status, as returned by waitpid(), or NULL.

  And in the documentation of waitpid
  (http://linux.die.net/man/2/waitpid) exit_status is described.

  You have to do something like this:
  if (WIFEXITED(exit_status) == FALSE) {
      return FALSE;
  }
  return (WEXITSTATUS(exit_status) == 1);

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/gnome-settings-daemon/+bug/1339244/+subscriptions