[Bug 1328556] Re: init/irqbalance should support $OPTIONS

[Louis Bouchard]

Verification done OK with test script in SRU for Trusty

** Tags removed: verification-needed
** Tags added: verification-done

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1328556

Title:
  init/irqbalance should support $OPTIONS

Status in “irqbalance” package in Ubuntu:
  Fix Released
Status in “irqbalance” source package in Trusty:
  Fix Committed

Bug description:
  [SRU justification]
  Without this modification, adding an $OPTIONS variable in /etc/default/irqbalance is useless.

  [Impact]
  Impossibility to add startup options using $OPTIONS

  [Fix]
  Add $OPTIONS to the upstart script similar to what is used in the SysV script

  [Test Case]
  Run the following script :

  #!/bin/bash

  
  apt-get update && apt-get -y install irqbalance

  cat << EOF >> /etc/default/irqbalance
  OPTIONS="--hintpolicy=ignore"
  EOF

  restart irqbalance

  Return=$(ps aux | grep irqbalance | grep -v grep | grep hintpolicy)

  if [[ -z $Return ]];then
     # Test fails : $OPTIONS not taken into account
     echo "Test Failed"
     exit -1
  else
     echo "Test Succeeded"
     exit 0
  fi

  [Regression]
  Risk of irqbalance not starting if invalid option were present in /etc/default/irqbalance previously

  [Original description of the problem]

  /etc/init.d/irqbalance supports setting an $OPTIONS variable to pass
  parameters to the irqbalance daemon

  /etc/init/irqbalance should also support an $OPTIONS variable.

  Usage example to workaround #1321425
  /etc/default/irqbalance
  OPTIONS="--hintpolicy=ignore"

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/irqbalance/+bug/1328556/+subscriptions