[Bug 1328556] Re: init/irqbalance should support $OPTIONS

[Chris J Arges]

Hello Grant, or anyone else affected,

Accepted irqbalance into trusty-proposed. The package will build now and
be available at
http://launchpad.net/ubuntu/+source/irqbalance/1.0.6-2ubuntu0.14.04.1 in
a few hours, and then in the -proposed repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to
enable and use -proposed.  Your feedback will aid us getting this update
out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested, and change the tag
from verification-needed to verification-done. If it does not fix the
bug for you, please add a comment stating that, and change the tag to
verification-failed.  In either case, details of your testing will help
us make a better decision.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance!

** Changed in: irqbalance (Ubuntu Trusty)
       Status: In Progress => Fix Committed

** Tags added: verification-needed

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1328556

Title:
  init/irqbalance should support $OPTIONS

Status in “irqbalance” package in Ubuntu:
  Fix Released
Status in “irqbalance” source package in Trusty:
  Fix Committed

Bug description:
  [SRU justification]
  Without this modification, adding an $OPTIONS variable in /etc/default/irqbalance is useless.

  [Impact]
  Impossibility to add startup options using $OPTIONS

  [Fix]
  Add $OPTIONS to the upstart script similar to what is used in the SysV script

  [Test Case]
  Run the following script :

  #!/bin/bash

  
  apt-get update && apt-get -y install irqbalance

  cat << EOF >> /etc/default/irqbalance
  OPTIONS="--hintpolicy=ignore"
  EOF

  restart irqbalance

  Return=$(ps aux | grep irqbalance | grep -v grep | grep hintpolicy)

  if [[ -z $Return ]];then
     # Test fails : $OPTIONS not taken into account
     echo "Test Failed"
     exit -1
  else
     echo "Test Succeeded"
     exit 0
  fi

  [Regression]
  Risk of irqbalance not starting if invalid option were present in /etc/default/irqbalance previously

  [Original description of the problem]

  /etc/init.d/irqbalance supports setting an $OPTIONS variable to pass
  parameters to the irqbalance daemon

  /etc/init/irqbalance should also support an $OPTIONS variable.

  Usage example to workaround #1321425
  /etc/default/irqbalance
  OPTIONS="--hintpolicy=ignore"

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/irqbalance/+bug/1328556/+subscriptions