[Bug 1306629] Re: [SRU] SDL_syswm.h can't find mir_toolkit/mir_client_library.h

[Scott Howard]

A) Workaround is to add: "-I/usr/include/mirclient
-I/usr/include/mircommon" to your compiler options.

B) Something is still odd here. Mir support was enabled in SDL2. You now
have to install libmirclient-dev and mircommon-dev and explicitly add
includes to mir header files in your program in order to compile any
SDL2 program, even if you don't use mir or have mir installed. Sure, Mir
will be the default next release - but that's next release, and trusty
was supposed to be an LTS release.

It's like having to install java in order to compile anything that uses
libc. (Hyperbole, but similar idea).

Enabling Mir support is great, but requiring developers to explicitly
include headers they don't know about and won't use seems odd.

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1306629

Title:
  [SRU] SDL_syswm.h can't find mir_toolkit/mir_client_library.h

Status in Mir:
  Invalid
Status in “libsdl2” package in Ubuntu:
  In Progress

Bug description:
  I believe something is wrong with MIR support. A daily build of openmw
  just failed with:

  /usr/include/SDL2/SDL_syswm.h:97:44: fatal error: mir_toolkit/mir_client_library.h: No such file or directory
   #include <mir_toolkit/mir_client_library.h>

  In SDL_syswm.h:
  #if defined(SDL_VIDEO_DRIVER_MIR)
  #include <mir_toolkit/mir_client_library.h>
  #endif

  the file is:
  /usr/include/mirclient/mir_toolkit/mir_client_library.h
  http://packages.ubuntu.com/search?searchon=contents&keywords=mir_client_library.h&mode=exactfilename&suite=trusty&arch=any

  openmw buildlog:
  https://launchpadlibrarian.net/172588668/buildlog_ubuntu-trusty-i386.openmw_0.29%2Bgit20140411.77-0~ubuntu14.04.1_FAILEDTOBUILD.txt.gz

  it built successfully until the fix for bug #1295389 libsdl2 commit
  hit that enabled mir.

  Assigning "high" since it has the potentially to cause a large number
  of FTBFS in the archive.

  
  SRU Info:
  *Note* This patch has landed in libsdl2 upstream:
  https://hg.libsdl.org/SDL/rev/274017846e73

  1) The issue is sdl2.pc does not include mir_cflags, so the headers are in an unknown location. So when programs compiled against SDL2 with mir enabled, it could not find the mir headers.
  2) A simple way to test the current Mir problem:
  http://paste.ubuntu.com/7271077/
  3) Regression potential: Very low, this is a 1 line patch, that adds the MIR_CFLAGS to the SDL_CFLAGS.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mir/+bug/1306629/+subscriptions