[Bug 1123950] Please test proposed package
Brian Murray
brian at ubuntu.com
Thu Nov 7 19:13:08 UTC 2013
Hello Kurt, or anyone else affected,
Accepted stud into precise-proposed. The package will build now and be
available at
http://launchpad.net/ubuntu/+source/stud/0.3-1ubuntu2.12.04.1 in a few
hours, and then in the -proposed repository.
Please help us by testing this new package. See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to
enable and use -proposed. Your feedback will aid us getting this update
out to other Ubuntu users.
If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested, and change the tag
from verification-needed to verification-done. If it does not fix the
bug for you, please add a comment stating that, and change the tag to
verification-failed. In either case, details of your testing will help
us make a better decision.
Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in
advance!
--
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1123950
Title:
/etc/init.d/stud restart does not start the daemon
Status in “stud” package in Ubuntu:
Fix Released
Status in “stud” source package in Precise:
Fix Committed
Status in “stud” source package in Quantal:
Fix Committed
Status in “stud” source package in Raring:
Fix Committed
Status in “stud” source package in Saucy:
Fix Committed
Bug description:
SRU justification :
Impact :
When using invoke-rc.d stud restart, stud is not restarted
since the children processes are still holding open sockets since children are not
killed when SIGTERM is sent to the parent
Fix :
Modify stud to handle termination of children upon reception of SIGTERM
Test Case :
1) Install stud
2) Create SSL certs with the following cmds:
$ openssl genrsa -des3 -passout pass:ubuntu -out server.key 2048
$ openssl rsa -passin pass:ubuntu -in server.key -out server.key.insecure
$ mv server.key server.key.secure
$ mv server.key.insecure server.key
$ openssl req -new -key server.key -out server.csr -subj "/C=FR/ST=Denial/L=LeChesnay/O=Dis/CN=ubuntu"
$ openssl x509 -req -days 365 -in server.csr -signkey server.key -out server.crt
$ cp server.crt /etc/ssl/certs
$ cp server.key /etc/ssl/private
$ openssl req -new -x509 -nodes -keyout /etc/stud/stud.pem -out /etc/stud/stud.pem -days 3650 -subj "/C=FR/ST=Denial/L=LeChesnay/O=Dis/CN=ubuntu"
3) configure stud :
$ cat << EOF > /etc/stud/stud.conf
OPTIONS="-b 127.0.0.1,8445"
CERT="/etc/stud/stud.pem"
EOF
4) Start stud
$ sudo invoke-rc.d stud start
One parent and one child stud process should be present
5) Restart stud
$ sudo invoke-rc.d stud restart
With the fix, stud parent and child process will be restarted. Without the fix, no more
stud process will be present.
Regression :
Minimal. Signal handler is enable for the parent process only. Triggered if
SIGTERM is received by the parent.
Original description of the problem :
I guess it is a race condition, as
/etc/init.d/stud stop; /etc/init.d/stud start
shows the same problem while adding a "sleep 1" before the call to
"do_start" fixes the problem.
There is also a (unrelated) bug in the function "do_stop()": there is
a variable
notfound=1
but it is not set to "0" in the for loop (as is the case in
'do_start'). This causes the return value to be 1:
[ $notfound -eq 1 ] && return 1
But this has nothing to do with the restart problem as both return
values 0 and 1 are in the same case statement, so no difference to
program flow.
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/stud/+bug/1123950/+subscriptions
More information about the Ubuntu-sponsors
mailing list