[Bug 1170325] Re: Facter 1.6.X not considering Qemu/KVM virtual type

[Brian Murray]

And quantal and precise.

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1170325

Title:
  Facter 1.6.X not considering Qemu/KVM virtual type

Status in “facter” package in Ubuntu:
  Fix Released
Status in “facter” source package in Precise:
  Triaged
Status in “facter” source package in Quantal:
  Triaged
Status in “facter” source package in Raring:
  Triaged

Bug description:
  [Impact]

  facter recognises a /proc/cpuinfo CPU model of "Common KVM processor"
  as a physical machine. facter is most often used with puppet, and
  causes puppet manifests to mis-classify virtual machines of this type
  and apply incorrect rules where the puppet manifests supplied by
  system administrators differ on this criterion.

  [Stable and Development Fix]

  A cherry-pick of the upstream fix, modified to be made minimal (one
  line). See the quilt patch for details.

  [Test Case 1]

  Run "facter is_virtual". On a physical machine, this should say false.
  On a virtual machine reporting in /proc/cpuinfo as "QEMU Virtual CPU"
  as well as a virtual machine reporting in /proc/cpuinfo as "Common KVM
  Processor", "facter is_virtual" should say true.

  [Test Case 2]

  As a shortcut, on Quantal and Raring you can fake the /proc/cpuinfo
  file as follows:

  mkdir -p /tmp/proc/{lower,upper,combined}
  cd /tmp/proc
  mount -t proc none lower
  mount -t tmpfs -o mode=755 none upper
  mount -t overlayfs -o lowerdir=lower,upperdir=upper none combined
  stop rsyslogd
  stop acpid
  umount /proc && mount --bind combined /proc

  Then you can edit /proc/cpuinfo and run facter to test behaviour as
  per Test Case 1.

  This is a hack and does not appear to work correctly in Precise.

  [Regression Potential]

  It looks like detection of other model strings in /proc/cpuinfo may
  have regressed upstream, fixed by a later commit. It's important to
  test that both model strings of "QEMU Virtual CPU" and "Common KVM
  processor" detect as virtual, and that another string (eg. "Other")
  detects as physical.

  [Original Description]

  On ubuntu 12.04 LTS, the official version for the facter package is
  1.6.5-ubuntu1.

  ii facter 1.6.5-1ubuntu1 collect and display facts about the system

  The is_virtual? method is not recognized on last version of KVM,
  because of the output of /proc/cpuinfo, which does not contains “Qemu
  Server” Infos.

  model name : Common KVM processor

  The workaround was added in the next versions of facter, and so I
  would like to provide you this patch, which fixes this bug on Ubuntu
  12.04 LTS.

  Best regards

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/facter/+bug/1170325/+subscriptions