[Bug 1163905] Re: Backport-Request: Failure in Duply's pre-scripts are muted

[Michael Terry]

I uploaded your precise debdiff to Ubuntu.  Now we wait for the SRU team
to approve it.  I didn't bother uploading the raring one, because we're
in Final Freeze right now.  In S, we can presumably just update to the
next version of duply.  I'll unsubscribe sponsors.

I had to make a few changes to your patch, Eduardo, that you might want to know about for future SRUs:
 * The convention for SRU versions is to use a minor number.  So instead of -1ubuntu1, use -1ubuntu0.1
 * You should always make sure to mention the bug number in debian/changelog
 * When making the first Ubuntu edit to a Debian package, make sure to run 'update-maintainer' in the source tree
 * Your patch added the "return" line in the wrong spot

** No longer affects: duply (Ubuntu Raring)

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1163905

Title:
  Backport-Request: Failure in Duply's pre-scripts are muted

Status in “duply” package in Ubuntu:
  Triaged
Status in “duply” source package in Precise:
  Triaged

Bug description:
  
  duply does not check the return status of pre and post scripts and therefore returns 0 even if there was a problem in the pre/post scripts which returned an error. 

  This issue happens every time and is 100% reproducible

  SRU Justification:
  [Impact]

   * When using duply, errors on pre/post scripts are not caught and
  therefore succeed even if there were problems.

  [Test Case]

   * Set up duply
   * Create a pre script containing simply 'exit 1' inside it.
   * Run 'duply srv pre'
   * See duply succeed and return 0

  --- Start running command PRE at 12:58:29.630 ---
  Running '/root/.duply/srv/pre' - FAILED (code 1)
  --- Finished state OK at 12:58:29.638 - Runtime 00:00:00.008 ---
  root at nas:~# echo $?
  0

  with the patch:

  --- Start running command PRE at 13:02:03.643 ---
  Running '/root/.duply/srv/pre' - FAILED (code 1)
  13:02:03.652 Task 'PRE' failed with exit code '1'.
  --- Finished state FAILED 'code 1' at 13:02:03.652 - Runtime 00:00:00.009 ---
  root at nas:~# echo $?
  1

  [Regression Potential]

   * The patch is minimal and has been accepted/committed upstream. 
   * This package has been tested on a virtual machine with the test case above and showed the right exit value. Minimal likelihood of regressions.

  ----
  Status:

   * Patch is the same as:
   * http://sourceforge.net/tracker/index.php?func=detail&aid=3609075&group_id=217745&atid=1041147
   * Packages agains precise: https://launchpad.net/~edamato/+archive/lp1163905

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/duply/+bug/1163905/+subscriptions