[Bug 1162876] Re: apt-cacher-ng data corruption with HTTP headers

[Steve Langasek]

Chris, I'm accepting this into precise-proposed because from Colin I
understand re-validating a prospective patch is quite time-consuming
with a long customer round-trip.  But the patch here is suboptimal; in
future SRUs, please avoid code changes unrelated to the bugs you're
trying to fix.

In this case, there are:

 - renamed members in a class (m_nReqRangeFrom, m_nReqRangeTo)
 - an API change that affects parsing behavior when an option appears more than once in the config, which is unrelated to the bugs here (SetOption)
 - renamed defines (EFLAG_DISCON, EFLAG_DO_DISCON)
 - logging changes

All of these are unrelated to the bugfixes, and make code review of the
diff more time-consuming and error-prone.  I've satisfied myself that
they're reasonably safe here, but such changes should not be included in
an SRU - an SRU should include the minimal change necessary to fix the
bug.

** Changed in: apt-cacher-ng (Ubuntu Precise)
       Status: In Progress => Fix Committed

** Tags added: verification-needed

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1162876

Title:
  apt-cacher-ng data corruption with HTTP headers

Status in “apt-cacher-ng” package in Ubuntu:
  Fix Released
Status in “apt-cacher-ng” source package in Precise:
  Fix Committed

Bug description:
  apt-cacher-ng is reporting hash mismatches for packages in an archive
  at random. This is due to the fact that apt-cacher-ng is storing the
  HTTP headers related to the package download in the .deb file.

  This issue happens intermittently on precise apt-cacher-ng
  0.7.2-1ubuntu1, but seems to be fixed in 0.7.4.

  SRU Justification:
  [Impact] 

   * When using apt-cacher-ng hash mismatches failures for packages can
  cause problems when installing packages.

  [Test Case]

   * Set up apt-cacher-ng
   * Intermittent failures due to hash-mismatches may occur in versions <= 0.7.2-1ubuntu1

  [Regression Potential]

   * This adds a few patches that fix the issue. Unfortuantely I was unable to find an upstream VCS to be able to separate out patches from each other. Therfore I tried to remove the very obvious bits of the code that did not address the issue. All of this code is already in newer versions of the package.
   * This package has been tested in an environment with a apt-cache-ng server and 10 client machines and has been run for days without any hash mismatches.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/apt-cacher-ng/+bug/1162876/+subscriptions