[Bug 1040213] Re: Request for new upstream version 1.3 upgrade

[Julian Taylor]

why do you wipe the crontab if the check_output fails for some reason?
this occurs several times
+        try:
+            subprocess.check_output(['crontab', '-l'])
+        except subprocess.CalledProcessError:
+            newcron = subprocess.Popen(['crontab', '-'], stdin = subprocess.PIPE)
+            newcron.communicate("")

I'm guessing this is a typo and it should be -l in the second call too.
I don't really see why you use the try, except at all
just stick with the second version or copy paste the check_output code into your program if you want python 2.6 compatibility

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1040213

Title:
  Request for new upstream version 1.3 upgrade

Status in “wakeup” package in Ubuntu:
  New

Bug description:
  Just a few bug fixes, minor in terms of code changed, but major in
  terms of usability improvement. Would be great to get this in before
  feature freeze....

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/wakeup/+bug/1040213/+subscriptions