[Bug 953392] [NEW] File /usr/share/gnome-pkg-tools/control.header contains one blank line to much at the end - Please remove it

[Launchpad Bug Tracker]

You have been subscribed to a public bug by Chris J Arges (christopherarges):

SRU Justification:
[Impact]
Gnome-pkg-tools produces non-standard control files. This is fixed in quantal, and is a simple removal of a blank line, thus backported easily to precise.

[Testcase]
See bug below.

[Regression Potential]
Minimal, this is a single removal of a blank line from control.header.

--

Hi everyone,

I've noticed that the file /usr/share/gnome-pkg-tools/control.header
contains one blank line to much at the end of the file. Please remove it
because it produces non standard control files.

Example from the package mutter:
File debian/control.in:
-------------------------------------------------
Source: mutter
Section: x11
....
-------------------------------------------------

File debian/control:
-------------------------------------------------
# This file is autogenerated. DO NOT EDIT!
#
# Modifications should be made to debian/control.in instead.
# This file is regenerated automatically in the clean target.

Source: mutter
Section: x11
...
-------------------------------------------------

This extra blank line causes issues with tools like pbuilder (automatic
installation of build dependencies doesn't work). Because of the blank
line the Source paragraph is no longer the first paragraph in the file.
The first paragraph then only consists of comments and thus pbuilder-
satisfydepends can't determine the build dependencies which yields a
build failure because of missing build dependencies...

References:
http://www.debian.org/doc/debian-policy/ch-controlfields.html#s-sourcecontrolfiles
Quote: "The first paragraph of the control file contains information about the source package in general. The subsequent sets each describe a binary package that the source tree builds."

https://answers.launchpad.net/launchpad/+question/151535
Quote: "The problem is the blank line in your debian/control file separating the commented out block and the initial "Source: gnome-orca" paragraph. A very strict reading of the Debian Policy Manual says this is invalid: you have an empty initial paragraph, and the Source paragraph as the second paragraph. Some tools may be more tolerant and skip the initial empty paragraph, however pbuilder-satisfydepends does not."

Please fix this little issue asap because it blocks automatic builds with pbuilder for certain Gnome packages.
This issue is present in all package versions from Lucid up to Precise. Please also note that not all editors show the additional blank line. You could use a hex editor to get rid of the last 0a in the file.

$ xxd /usr/share/gnome-pkg-tools/control.header
...
00000a0: 2074 6172 6765 742e 0a0a                  target...

Best,

Michael

** Affects: gnome-pkg-tools (Ubuntu)
     Importance: High
     Assignee: Logan Rosen (logan)
         Status: Fix Released

** Affects: gnome-pkg-tools (Ubuntu Precise)
     Importance: High
     Assignee: Chris J Arges (christopherarges)
         Status: In Progress

** Affects: gnome-pkg-tools (Debian)
     Importance: Unknown
         Status: New

-- 
File /usr/share/gnome-pkg-tools/control.header contains one blank line to much at the end - Please remove it
https://bugs.launchpad.net/bugs/953392
You received this bug notification because you are a member of Ubuntu Sponsors Team, which is subscribed to the bug report.