[Merge] lp:~matttbe/ubuntu/quantal/rhythmbox/1010619_795765 into lp:ubuntu/quantal/rhythmbox

[Matthieu Baerts]

Matthieu Baerts has proposed merging lp:~matttbe/ubuntu/quantal/rhythmbox/1010619_795765 into lp:ubuntu/quantal/rhythmbox.

Requested reviews:
  Ubuntu Sponsors Team (ubuntu-sponsors)
Related bugs:
  Bug #795765 in rhythmbox (Ubuntu Quantal): "CDs won't resume playing after being paused"
  https://bugs.launchpad.net/ubuntu/quantal/+source/rhythmbox/+bug/795765
  Bug #1010619 in rhythmbox (Ubuntu Quantal): "[SRU] Rhythmbox 2.97 and 2.98 freezes with large collection"
  https://bugs.launchpad.net/ubuntu/quantal/+source/rhythmbox/+bug/1010619

For more details, see:
https://code.launchpad.net/~matttbe/ubuntu/quantal/rhythmbox/1010619_795765/+merge/133343

[IMPACT]

 * Rhythmbox freezes when using a large collection. (LP: #1010619)
 * Rhythmbox won't resume playing an audio CD if you pause it. (LP: #795765)

[TESTCASE]

 * Rhythmbox freezes when using a large collection. (LP: #1010619)
  * It happens with a large collection.
  * It's due to a deadlock between db load and rhythmdb_add_uri_with_types and it's possible that it's not easy to reproduce this bug. Maybe it can be interesting to slow down the hard disk (e.g. by copying a large file when opening Rhythmbox with a lot of files in its collection)
  * With the previous version and after a few seconds, Rhythmbox will freeze.
  * (this fix has been confirmed by a few people in the bug #1010619)

 * Rhythmbox won't resume playing an audio CD if you pause it. (LP: #795765)
  * Insert an audio CD (not an mp3 CD but a traditional one you'd buy from the music store)
  * Test if play and pause work.

[Regression Potential]

 * Rhythmbox freezes when using a large collection. (LP: #1010619)
  * According to RB devs: None => http://git.gnome.org/browse/rhythmbox/commit/?id=a2ead52faa45a37f28dff1e94cad5f0dadd28129
  * This deadlock has been fixed by RB devs and now it seems they understand why there was a deadlock

 * Rhythmbox won't resume playing an audio CD if you pause it. (LP: #795765)
  * None, audio CD playback is already very badly broken.

[ Other Info ]

 * A new version (2.98-0ubuntu2) has been uploaded to Raring repos and it contains the same patches to fix these bugs.
 * About the version: I wanted to use the version 2.97-1ubuntu5.1 just to be sure that the version number does not conflict with any later and future versions in other Ubuntu releases but a new version has been uploaded a few days ago with the version 2.97-1ubuntu6. I hope I can use the version 2.97-1ubuntu7

Thank you for your help!
-- 
https://code.launchpad.net/~matttbe/ubuntu/quantal/rhythmbox/1010619_795765/+merge/133343
Your team Ubuntu Sponsors Team is requested to review the proposed merge of lp:~matttbe/ubuntu/quantal/rhythmbox/1010619_795765 into lp:ubuntu/quantal/rhythmbox.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 287102 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-sponsors/attachments/20121107/02f822b2/attachment-0001.diff>