[Bug 954993] Re: Uses deprecated GTK3 API

[Pojar George]

1. Patch to resolve build warnings about is used deprecated GTK3 API:
   build log: https://launchpadlibrarian.net/96639389/buildlog_ubuntu-precise-i386.gnomeradio_1.8-2_BUILDING.txt.gz

2. GTK+ contains a GtkVolumeButton (Gnomeradio is write on GTK+).
   I guess it would be better to use this standard widget, instead of the custom BaconVolumeButton which is used now.
   Patch to replace BaconVolumeButton with GtkVolumeButton

3. Fixed problems with Gtk3 events and signal:
   GLib-GObject-WARNING **: gsignal.c:2295: signal `expose-event' is invalid for instance `0x23b6030'

4. Use standard gstreamer functions to parse a description
   GStreamer contains several functions to parse a description to a bin (gst_parse_bin_from_description[*]).
   Gnomeradio contains two custom functions to do this, but i don't see anything special about those implementations.
   They can, imho, be exchanged for their standard counterpart.

[*]http://gstreamer.freedesktop.org/data/doc/gstreamer/head/gstreamer/html
/gstreamer-GstParse.html#gst-parse-bin-from-description

5. Update debian/control:
   + moved project homepage field from description to the correct location.
   + add suggests field: lirc-x

** Patch removed: "patch (gnomeradio_1.8-2ubuntu1)"
   https://bugs.launchpad.net/ubuntu/+source/gnomeradio/+bug/954993/+attachment/2874966/+files/gnomeradio_1.8-2ubuntu1.debdiff

** Patch added: "gnomeradio_1.8-2.1"
   https://bugs.launchpad.net/ubuntu/+source/gnomeradio/+bug/954993/+attachment/2878393/+files/gnomeradio_1.8-2.1.debdiff

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/954993

Title:
  Uses deprecated GTK3 API

Status in “gnomeradio” package in Ubuntu:
  Confirmed

Bug description:
  Building gnomeradio-1.8-2 source in current precise with GTK3 give
  warnings:

  Extract from build log:
  -------------------------------------------------------------------------------------
  gui.c: In function 'gnome_radio_gui':
  gui.c:922:2: warning: 'gtk_vbox_new' is deprecated (declared at /usr/include/gtk-3.0/gtk/deprecated/gtkvbox.h:60): Use 'gtk_box_new' instead [-Wdeprecated-declarations]
  gui.c:923:2: warning: 'gtk_hbox_new' is deprecated (declared at /usr/include/gtk-3.0/gtk/deprecated/gtkhbox.h:62): Use 'gtk_box_new' instead [-Wdeprecated-declarations]
  gui.c:924:2: warning: 'gtk_hbox_new' is deprecated (declared at /usr/include/gtk-3.0/gtk/deprecated/gtkhbox.h:62): Use 'gtk_box_new' instead [-Wdeprecated-declarations]
  gui.c:925:2: warning: 'gtk_vbox_new' is deprecated (declared at /usr/include/gtk-3.0/gtk/deprecated/gtkvbox.h:60): Use 'gtk_box_new' instead [-Wdeprecated-declarations]
  gui.c:926:2: warning: 'gtk_hbox_new' is deprecated (declared at /usr/include/gtk-3.0/gtk/deprecated/gtkhbox.h:62): Use 'gtk_box_new' instead [-Wdeprecated-declarations]
  gui.c:937:2: warning: 'gtk_hscale_new' is deprecated (declared at /usr/include/gtk-3.0/gtk/deprecated/gtkhscale.h:60): Use 'gtk_scale_new' instead [-Wdeprecated-declarations]
  gui.c:962:2: warning: 'gtk_vseparator_new' is deprecated (declared at /usr/include/gtk-3.0/gtk/deprecated/gtkvseparator.h:66): Use 'gtk_separator_new' instead [-Wdeprecated-declarations]
  gui.c:965:2: warning: 'gtk_vseparator_new' is deprecated (declared at /usr/include/gtk-3.0/gtk/deprecated/gtkvseparator.h:66): Use 'gtk_separator_new' instead [-Wdeprecated-declarations]
  -------------------------------------------------------------------------------------

  and more (see full build log attached)

  I will make a patch (soon).

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/gnomeradio/+bug/954993/+subscriptions