[Bug 1023434] Re: Update for precise with translation bug fix - debdiff provided

[Jamie Strandboge]

Unsubscribing ubuntu-sponsors since this has been sponsored to precise-
proposed. Feel free to resubscribe if there is anything else to review.

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1023434

Title:
  Update for precise with translation bug fix - debdiff provided

Status in “onboard” package in Ubuntu:
  Fix Released
Status in “onboard” source package in Precise:
  Fix Committed

Bug description:
  [Impact]
  Assume a user not able to use a hardware keyboard and therefore uses the onscreen keyboard Onboard shipping by default with Ubuntu.   This is the case for example if there is no hardware keyboard on his device running Ubuntu (tabletpc, kiosks, ...) or the user has a disability or...

  Moreover, assume that the language file for Onboard has errors in the
  names of the fields. This is for example the case for the Czech
  onboard.mo file in the current language-pack-gnome-cs-base package and
  the update that is being released tomorrow. (I have attached the
  onboard.mo file to this bug thread in case this bug gets only reviewed
  after the translation in the language pack has been fixed.) I cited
  the Czech translation here, but this is not the only language for
  which we got notifications about crashes due to errors in the
  translation files.

  Such a user will not be able to use his computer as Onboard will crash
  (because of the error in the language file) and he will be left
  without keyboard to interact with the computer.

  Thus, this problem affects all users that have to rely on Onboard for
  which there is an error in the translation file. It is a very severe
  bug in this case as the user will not be able to control the computer.

  [Test Case]
  How to reproduce the bug:

  1. Install the Czech language pack. Alternatively you can also only
  install the language-pack-gnome-cs-base package debian package; this
  package contains the Onboard translation file. (I have also added the
  onboard.mo file with the error to the bug thread; but you have to
  remove the indication of the path from the filename.)

  2. Switch your computer to Czech and try to start Onboard.
  Alternatively without switching the computer to Czech: try to start
  Onboard from the command line by telling it to use the czech language;
  here is the command to write in the terminal: LANGUAGE=cs onboard

  3a. Result with Onboard shipping currently with precise:
  $ LANGUAGE=cs onboard
  Traceback (most recent call last):
    File "/usr/lib/python2.7/dist-packages/Onboard/OnboardGtk.py", line 86, in do_activate
      self.init()
    File "/usr/lib/python2.7/dist-packages/Onboard/OnboardGtk.py", line 101, in init
      config.init()
    File "/usr/lib/python2.7/dist-packages/Onboard/Config.py", line 235, in init
      self.load_system_defaults(paths)
    File "/usr/lib/python2.7/dist-packages/Onboard/ConfigUtils.py", line 399, in load_system_defaults
      .format(filename=filename))
  KeyError: u'paths'
  Thus, Onboard does not even start.

  3b. Result with Onboard enhanced by the patch whose debian source is attached to this bug thread:
  $ LANGUAGE=cs onboard
  2012-07-20 21:25:57,811:WARNING:utils: _format: Skipping bad translation msgid='Loading system defaults from {filename}' msgstr='Načítání výchozího nastavení z {paths}' KeyError: u'paths'
  Thus, Onboard informs the user about the error in the translation file, but does not crash and remains usable. (To get rid of the error message the translation file has to be fixed. Of course, a user that has not launched Onboard from the terminal does not see the error message, but the fact is that Onboard remains usable.)

  [Regression Potential]
  People not running Onboard will not see any difference as the is no real package depending on Onboard:
  $ apt-cache rdepends onboard
  onboard
  Reverse Depends:
    onboard:i386
    onboard:i386
    xubuntu-desktop
    ubuntu-sugar-remix
    ubuntu-desktop
  $

  The changes from this patch were derived from version 0.97.1 of Onboard that is already available in quantal and that has been tested in different environments. Quoting marmuta, the main Onboard coder since quite some time, from message #19 of the other SRU bug thread
  https://bugs.launchpad.net/ubuntu/precise/+source/onboard/+bug/999111 :
  "Regression testing for all releases is (still) done manually by checklist in four desktop environments: unity, unity-2d, gnome-shell and gnome classic (with and without compositing)."

  Marmuta can send you the list of tests he is performing, if you need
  it.

  The patch has also been tested, but less than the releases, as the
  changes were already tested with the 0.97.1 release of Onboard that
  happened before this patch was derived from it.

  [Original Report]

  Here is an update for a SRU for Onboard shipping currently with precise that addresses the bugs that have been filed against Onboard 0.97.0 because of crashes of Onboard due to errors in the translation files:
  https://bugs.launchpad.net/onboard/+bug/999155
  https://bugs.launchpad.net/bugs/1013279

  The patch proposed here has been derived from Onboard 0.97.1 after it turned out, that 0.97.1 is not a good candidate for an SRU because of the huge difference to version 0.97.0. You might have a look at comment 18, 19 and 20 of the following bug thread:
  https://bugs.launchpad.net/ubuntu/precise/+source/onboard/+bug/999111

  Onboard 0.97.1, which the patch has been derived from, is in Ubuntu
  Quantal and there has not been any new bug filed because of crashes
  due to errors in language files until now.

  If the language packs have not been updated meanwhile, the fix can be tested by using the Czech localisation:
  - without patch: Onboard crashes because of the error in the cs localisation file
  - with the path: the error in the cs localisation file is catched by the code in Onboard that does not crash anymore

  The direct impact of problems in Onboard should not be very widespread, as apart the ubuntu-* metapackages, there is no other package depending on it:
  $ apt-cache rdepends onboard
  onboard
  Reverse Depends:
    onboard:i386
    onboard:i386
    xubuntu-desktop
    ubuntu-sugar-remix
    ubuntu-desktop
  $

  If you need any additional pieces of information, please do not
  hesitate to ask for it.

  Thanks in advance for taking this SRU into account.

  Cheers,

  Francesco

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/onboard/+bug/1023434/+subscriptions