[Bug 908449] Re: FTBFS: error: 'gtk_hbox_new' is deprecated (declared at /usr/include/gtk-3.0/gtk/deprecated/gtkhbox.h:64): Use 'gtk_box_new' instead [-Werror=deprecated-declarations]

[Martin Pitt]

Adding upstream task so that the patch can be applied there, too.

** Also affects: indicator-datetime
   Importance: Undecided
       Status: New

** Changed in: indicator-datetime
       Status: New => Confirmed

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/908449

Title:
  FTBFS: error: 'gtk_hbox_new' is deprecated (declared at
  /usr/include/gtk-3.0/gtk/deprecated/gtkhbox.h:64): Use 'gtk_box_new'
  instead [-Werror=deprecated-declarations]

Status in The Date and Time Indicator:
  Confirmed
Status in “indicator-datetime” package in Ubuntu:
  Fix Released

Bug description:
  After migrating from libpolkit-gtk-1-dev to libpolkit-gobject-1-dev,
  the following error comes up in the gtk3 build:

  
  #	source='indicator-datetime.c' object='libdatetime_la-indicator-datetime.lo' libtool=yes 
  /bin/bash ../libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I/mnt/devel/andreas/ubuntu/indicator-datetime/indicator-datetime-0.3.1/./src -I..    -pthread -I/usr/include/gtk-3.0 -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/pango-1.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/libdbusmenu-0.4 -I/usr/include/libindicator-0.4 -I/usr/include/libido3-0.1   -Wall -Werror -DTIMEZONE_FILE="\"/etc/timezone\"" -DG_LOG_DOMAIN=\"Indicator-Datetime\" -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Wformat-security -Werror=format-security -Wall -c -o libdatetime_la-indicator-datetime.lo `test -f 'indicator-datetime.c' || echo '/mnt/devel/andreas/ubuntu/indicator-datetime/indicator-datetime-0.3.1/./src/'`indicator-datetime.c
  libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I/mnt/devel/andreas/ubuntu/indicator-datetime/indicator-datetime-0.3.1/./src -I.. -pthread -I/usr/include/gtk-3.0 -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/pango-1.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/libdbusmenu-0.4 -I/usr/include/libindicator-0.4 -I/usr/include/libido3-0.1 -Wall -Werror -DTIMEZONE_FILE=\"/etc/timezone\" -DG_LOG_DOMAIN=\"Indicator-Datetime\" -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Wformat-security -Werror=format-security -Wall -c /mnt/devel/andreas/ubuntu/indicator-datetime/indicator-datetime-0.3.1/./src/indicator-datetime.c  -fPIC -DPIC -o .libs/libdatetime_la-indicator-datetime.o
  /mnt/devel/andreas/ubuntu/indicator-datetime/indicator-datetime-0.3.1/./src/indicator-datetime.c: In function 'new_appointment_item':
  /mnt/devel/andreas/ubuntu/indicator-datetime/indicator-datetime-0.3.1/./src/indicator-datetime.c:1264:2: error: 'gtk_hbox_new' is deprecated (declared at /usr/include/gtk-3.0/gtk/deprecated/gtkhbox.h:64): Use 'gtk_box_new' instead [-Werror=deprecated-declarations]
  /mnt/devel/andreas/ubuntu/indicator-datetime/indicator-datetime-0.3.1/./src/indicator-datetime.c: In function 'new_timezone_item':
  /mnt/devel/andreas/ubuntu/indicator-datetime/indicator-datetime-0.3.1/./src/indicator-datetime.c:1475:2: error: 'gtk_hbox_new' is deprecated (declared at /usr/include/gtk-3.0/gtk/deprecated/gtkhbox.h:64): Use 'gtk_box_new' instead [-Werror=deprecated-declarations]
  cc1: all warnings being treated as errors

  make[4]: *** [libdatetime_la-indicator-datetime.lo] Error 1
  make[4]: Leaving directory `/mnt/devel/andreas/ubuntu/indicator-datetime/indicator-datetime-0.3.1/build/gtk3/src'
  make[3]: *** [all] Error 2
  make[3]: Leaving directory `/mnt/devel/andreas/ubuntu/indicator-datetime/indicator-datetime-0.3.1/build/gtk3/src'
  make[2]: *** [all-recursive] Error 1
  make[2]: Leaving directory `/mnt/devel/andreas/ubuntu/indicator-datetime/indicator-datetime-0.3.1/build/gtk3'
  make[1]: *** [all] Error 2
  make[1]: Leaving directory `/mnt/devel/andreas/ubuntu/indicator-datetime/indicator-datetime-0.3.1/build/gtk3'
  make: *** [debian/stamp-makefile-build/gtk3] Error 2

  Attached is a patch that fixes compilation by using the correct
  function depending on gtk version.

To manage notifications about this bug go to:
https://bugs.launchpad.net/indicator-datetime/+bug/908449/+subscriptions