[Bug 896902] Re: Please merge gtk-led-askpass 0.11-1 (universe) from Debian unstable

[Evan Broder]

Leo, it looks like you added the -Wno-error=unused-result from the last
version.

Please don't do that. The unused-result warning catches code with
insufficient error handling, and insufficient error handling tends to
lead to subtle bugs and occasionally security vulnerabilities.

There's a brief write-up on the wiki
(https://wiki.ubuntu.com/ToolChain/CompilerFlags#Ignoring_return_code_of_write.28.29)
about dealing with warn_unused_result functions. Could you please
consult those and see if you can patch the source in a way that causes
it to actually handle return values correctly?

(I'm going to go ahead and unsubscribe ubuntu-sponsors for the time
being, but feel free to resubscribe at any point)

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/896902

Title:
  Please merge gtk-led-askpass 0.11-1 (universe) from Debian unstable

Status in “gtk-led-askpass” package in Ubuntu:
  Confirmed

Bug description:
  gtk-led-askpass (0.11-1) unstable; urgency=low

    * New upstream version.
      - Doesn't pass messages as format strings. Closes: #572634.
    * Convert to Debhelper 7.

   -- Dafydd Harries <daf at debian.org>  Wed, 19 Jan 2011 16:23:21 -0500

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/gtk-led-askpass/+bug/896902/+subscriptions