[Merge] lp:~clint-fewbar/ubuntu/natty/libedit/fix-terminal-grabbing into lp:ubuntu/libedit

[Clint Byrum]

Clint Byrum has proposed merging lp:~clint-fewbar/ubuntu/natty/libedit/fix-terminal-grabbing into lp:ubuntu/libedit.

Requested reviews:
  Ubuntu Sponsors Team (ubuntu-sponsors)
Related bugs:
  #322214 php (via libedit using_history()) incorrectly opens stdin
  https://bugs.launchpad.net/bugs/322214

For more details, see:
https://code.launchpad.net/~clint-fewbar/ubuntu/natty/libedit/fix-terminal-grabbing/+merge/47505

So in NetBSD, tgetent is just termcap, and doesn't do as much to the terminal. For this reason, the upstream library may not be too inclined to accept this patch, though I will submit it anyway.

This change simply avoids calling tgetent if stdout is not a tty. I do think there is something wrong with ncurses that it would so aggressively setup the controlling terminal just during the tgetent() call, but that seems to be the expected behavior and so probably shouldn't be changed.

Anyway, this fixes the php issue and the test case program as well.
-- 
https://code.launchpad.net/~clint-fewbar/ubuntu/natty/libedit/fix-terminal-grabbing/+merge/47505
Your team Ubuntu Sponsors Team is requested to review the proposed merge of lp:~clint-fewbar/ubuntu/natty/libedit/fix-terminal-grabbing into lp:ubuntu/libedit.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 2176 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-sponsors/attachments/20110126/ab3445ea/attachment-0001.diff>