[Merge] lp:~mathieu-tl/ubuntu/natty/plymouth/lsb-release-version into lp:ubuntu/plymouth

[Steve Langasek]

Review: Needs Fixing
$ sudo dpkg -i ../plymouth-theme-kubuntu-text_0.8.2-2ubuntu10_amd64.deb 
[sudo] password for vorlon: 
Selecting previously deselected package plymouth-theme-kubuntu-text.
(Reading database ... 295450 files and directories currently installed.)
Unpacking plymouth-theme-kubuntu-text (from .../plymouth-theme-kubuntu-text_0.8.2-2ubuntu10_amd64.deb) ...
Setting up plymouth-theme-kubuntu-text (0.8.2-2ubuntu10) ...
update-alternatives: using /lib/plymouth/themes/kubuntu-text/kubuntu-text.plymouth to provide /lib/plymouth/themes/text.plymouth (text.plymouth) in auto mode.
update-initramfs: deferring update (trigger activated)
Processing triggers for initramfs-tools ...
update-initramfs: Generating /boot/initrd.img-2.6.35-24-generic
$ sudo dpkg --remove plymouth-theme-kubuntu-text
(Reading database ... 295451 files and directories currently installed.)
Removing plymouth-theme-kubuntu-text ...
update-alternatives: using /lib/plymouth/themes/ubuntu-text/ubuntu-text.plymouth to provide /lib/plymouth/themes/text.plymouth (text.plymouth) in auto mode.
rmdir: failed to remove `/lib/plymouth/themes': Directory not empty
rmdir: failed to remove `/lib/plymouth': Directory not empty
update-initramfs: deferring update (trigger activated)
Processing triggers for initramfs-tools ...
update-initramfs: Generating /boot/initrd.img-2.6.35-24-generic
$ ls -ld /lib/plymouth/themes/kubuntu-text/
drwxr-xr-x 2 root root 4096 2011-01-20 15:37 /lib/plymouth/themes/kubuntu-text/
$

Installing and removing the package leaves an orphaned directory behind, because the generated file isn't removed until the postrm which is after dpkg has removed the package's file list.

The proper fix for this is to do the removal in prerm remove instead of postrm remove as I suggested.  I realize this is awkward because other removals are also currently being done in the postrm; that's *also* a bug, but we shouldn't compound it here.  I'm happy to either accept a fix from you that moves all of this code from the postrm to the prerm, or to make this change myself and merge your branch on top of it.  Let me know your preference.
-- 
https://code.launchpad.net/~mathieu-tl/ubuntu/natty/plymouth/lsb-release-version/+merge/45095
Your team Ubuntu Sponsors Team is requested to review the proposed merge of lp:~mathieu-tl/ubuntu/natty/plymouth/lsb-release-version into lp:ubuntu/plymouth.