[Merge] lp:~mathieu-tl/ubuntu/natty/plymouth/lsb-release-version into lp:ubuntu/plymouth
Steve Langasek
steve.langasek at canonical.com
Mon Jan 10 22:32:47 UTC 2011
Review: Needs Fixing
Hi Mathieu,
+ sed -i -re \
+ "/\[ubuntu-text\]/ {
+ N;
+ s/(title=Ubuntu ).*\$/\1$(lsb_release -rs)/
+ }" /lib/plymouth/themes/ubuntu-text/ubuntu-text.plymouth
This approach will invalidate the checksum on the file that is listed in /var/lib/dpkg/info/plymouth-theme-ubuntu-text.md5sums, which is suboptimal. Instead, can you ship the stock file under /usr/share/plymouth (perhaps called '/usr/share/plymouth/ubuntu-text.plymouth.in'), creating the file under /lib/plymouth/themes in the postinst and removing it in the prerm (the latter only on package removal, i.e., $1 == remove)?
--
https://code.launchpad.net/~mathieu-tl/ubuntu/natty/plymouth/lsb-release-version/+merge/45095
Your team Ubuntu Sponsors Team is requested to review the proposed merge of lp:~mathieu-tl/ubuntu/natty/plymouth/lsb-release-version into lp:ubuntu/plymouth.
More information about the Ubuntu-sponsors
mailing list