[Merge] lp:~nataliabidart/ubuntu/natty/magicicada/magicicada-0.3.0 into lp:ubuntu/magicicada

[Naty Bidart]

> Hi looks ok, but a couple of small things pile up:
> * changelog is a bit weirdly formatted (text indented to the same level as the
> bullets.

> * You can use this syntax: (LP: #587020, #643195)

> * I'd prefer something a little more concrete than "updated dependency list".
>   It looks like: sorted depends, dropped depends-indep, depend on python-
> ubuntu-one-client (>= foo), depend on python-xdg

Fixed as per suggestion.

> * No mention of the standards version update (these are traditionally
> changelogged as "Bumped Standards-Version to X.Y.Z (no changes needed)"

Added (I bumped the version sin I got a lintian warning).

> * No mention of the maintainer change in the changelog. Should the maintainer
> not be Ubuntu Developers <ubuntu-devel-discuss at lists.ubuntu.com>?

I'm not sure, Elliot used to do the package maintenance but now is just Facundo Batista and me. I thought we had to put the actual maintainers on that field.
Can you please confirm?

> * No mention of the description change.

Added.

> * Copyright:
>   - I assume the copyright years need a bump.

Added.

>   - DEP5 has evolved quite a bit, at some point this file should be updated to
> match the current standards.

Sorry for my ignorance, what is DEP5? And how should it be updated?

>   - The short GPL licence grant should be included before the "full text"
> notice.

I'm a bit lost, in which file this needs to be changed?

> * At some point, you should consider migrating to dh_python2, AFAIK doko is
> quite keen for Ubuntu-specific packages to migrate during natty.

Hum, my ignorance strikes again. I'm not using explicitly dh_python to build the package. Could you please be more specific where dh_python2 should be used?

Thanks a lot for the feedback!
-- 
https://code.launchpad.net/~nataliabidart/ubuntu/natty/magicicada/magicicada-0.3.0/+merge/45528
Your team Ubuntu Sponsors Team is requested to review the proposed merge of lp:~nataliabidart/ubuntu/natty/magicicada/magicicada-0.3.0 into lp:ubuntu/magicicada.