[Bug 724310] Re: [FTBFS] bastet-0.41-6 failed to build on natty machine

[Bhavani Shankar]

Hello tarun again

First of all a very good try at fixing FTBFS mate, Here are a few quick
observations

1. Please set the maintainer to Ubuntu Developers (In the future you can
use update-maintainer script from ubuntu-dev-tools package to set the
same)

2. I am a bit skeptical about what this patch hunk does exactly

diff -u bastet-0.41/debian/patches/01_Makefile.patch bastet-0.41/debian/patches/01_Makefile.patch
--- bastet-0.41/debian/patches/01_Makefile.patch
+++ bastet-0.41/debian/patches/01_Makefile.patch
@@ -5,8 +5,10 @@
 #
 # Desc: Adding destdir and fixing some perms.
 
---- a/Makefile
-+++ b/Makefile
+Index: bastet-0.41/Makefile
+===================================================================
+--- bastet-0.41.orig/Makefile	2004-10-19 19:54:58.000000000 +0200
++++ bastet-0.41/Makefile	2008-01-27 15:55:35.000000000 +0100
 @@ -1,8 +1,8 @@
  #makefile for bastet (c) 2004 Federico Poloni
  
@@ -18,17 +20,15 @@
  HISCORE=bastet.scores
  
  #in order to handle highscores properly, bastet must be setuid.
-@@ -11,8 +11,8 @@
+@@ -11,7 +11,7 @@
  GAME_USER=games
  
  CC=gcc
 -CFLAGS=-Wall -DHIGHSCORE_FILE=\"$(DATA_PREFIX)$(HISCORE)\"
--LDFLAGS=-lncurses
 +CFLAGS=-Wall -DHIGHSCORE_FILE=\"$(DATA_PREFIX)$(HISCORE)\" $(DEBCFLAGS)
-+LDFLAGS=-lcurse
+ LDFLAGS=-lncurses
  SOURCES=main.c game.c highscore.c bast.c
  EXNAME=bastet
- 
 @@ -39,8 +39,3 @@
  
  install: $(EXNAME)


so please explain the above part and for patches in the future please use DEP-3 compliant description as described here

http://dep.debian.net/deps/dep3/

3. Please improve your patch naming here

--- bastet-0.41.orig/debian/patches/FTBFS
+++ bastet-0.41/debian/patches/FTBFS

and please use dep-3 headers to describe any patch as said above (patch
naming could be something like, as an example if the package is FTBFS
due to a missing link library with respect to binutils or linking order
changes lets say, then the patch could be named as binutils_gold.patch
as an instance so that its clear that package ftbfs due to binutils-
gold)

4. Please make your changelog more verbose stating the reason why its
FTBFS and what change you have proposed to fix the same

(as an example please see:

https://launchpad.net/ubuntu/natty/+source/gbgoffice/1.4-7ubuntu1)

(PS: I haven't tried to build the package with your patch and this was
just a quick overview of the patch you supplied)

Marking as incomplete and unsubscribing sponsors in the meantime

Please resubscribe when ready

Keep up the work going mate!

regards and thanks!

** Changed in: bastet (Ubuntu)
       Status: Confirmed => Incomplete

-- 
You received this bug notification because you are a member of Ubuntu
Sponsors Team, which is a direct subscriber.
https://bugs.launchpad.net/bugs/724310

Title:
  [FTBFS] bastet-0.41-6 failed to build on natty machine

Status in “bastet” package in Ubuntu:
  Incomplete

Bug description:
  Binary package hint: bastet

  This package failed to build from source on natty machine.
  Thank you